Changeset 72757 in webkit

Timestamp:

Nov 26, 2010 3:52:32 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-11-26 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Blur shadow for rectangle fill
​https://bugs.webkit.org/show_bug.cgi?id=44488

New fast canvas test to ensure fillRect shadow (with and without blur).

• fast/canvas/canvas-fillRect-shadow-expected.txt: Added.
• fast/canvas/canvas-fillRect-shadow.html: Added.
• fast/canvas/script-tests/canvas-fillRect-shadow.js: Added.

2010-11-26 Helder Correia <​helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Blur shadow for rectangle fill
​https://bugs.webkit.org/show_bug.cgi?id=44488

Shadow color opacity needs to be set when blurring shadow with
ContextShadow.

Test: fast/canvas/canvas-fillRect-shadow.html

• platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/canvas-fillRect-shadow-expected.txt (added)
• LayoutTests/fast/canvas/canvas-fillRect-shadow.html (added)
• LayoutTests/fast/canvas/script-tests/canvas-fillRect-shadow.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/qt/GraphicsContextQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-11-26  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] Blur shadow for rectangle fill
+        https://bugs.webkit.org/show_bug.cgi?id=44488
+
+        New fast canvas test to ensure fillRect shadow (with and without blur).
+
+        * fast/canvas/canvas-fillRect-shadow-expected.txt: Added.
+        * fast/canvas/canvas-fillRect-shadow.html: Added.
+        * fast/canvas/script-tests/canvas-fillRect-shadow.js: Added.
+
 2010-11-26  Helder Correia  <helder@sencha.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-11-26  Helder Correia  <helder@sencha.com>
+
+        Reviewed by Ariya Hidayat.
+
+        [Qt] Blur shadow for rectangle fill
+        https://bugs.webkit.org/show_bug.cgi?id=44488
+
+        Shadow color opacity needs to be set when blurring shadow with
+        ContextShadow.
+
+        Test: fast/canvas/canvas-fillRect-shadow.html
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::fillRect):
+
 2010-11-26  Hans Wennborg  <hans@chromium.org>
 

trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

@@ -708 +708 @@
                 QPainter* shadowPainter = shadow->beginShadowLayer(p, normalizedRect);
                 if (shadowPainter) {
+                    shadowPainter->setOpacity(static_cast<qreal>(shadow->m_color.alpha()) / 255);
                     shadowPainter->fillRect(normalizedRect, p->brush());
                     shadow->endShadowLayer(p);