Changeset 73137 in webkit

Timestamp:

Dec 2, 2010 8:33:11 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-02 Vincent Scheib <​scheib@chromium.org>

Reviewed by Darin Fisher.

[chromium] histograms api updated in WebKitClient and added to ChromiumBridge
​https://bugs.webkit.org/show_bug.cgi?id=50285

Test by loading "about:histograms" after navigating to accelerated pages.

• platform/chromium/ChromiumBridge.h: api update.

2010-12-02 Vincent Scheib <​scheib@chromium.org>

Reviewed by Darin Fisher.

[chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
​https://bugs.webkit.org/show_bug.cgi?id=50285

Test by loading "about:histograms" after navigating to accelerated pages.

• public/WebKitClient.h: (WebKit::WebKitClient::histogramCustomCounts): api update. (WebKit::WebKitClient::histogramEnumeration): api update.
• src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::histogramCustomCounts): api update. (WebCore::ChromiumBridge::histogramEnumeration): api update.
• src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.

Location:

trunk

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/chromium/ChromiumBridge.h (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/public/WebKitClient.h (modified) (1 diff)
• WebKit/chromium/src/ChromiumBridge.cpp (modified) (1 diff)
• WebKit/chromium/src/WebViewImpl.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-02  Vincent Scheib  <scheib@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [chromium] histograms api updated in WebKitClient and added to ChromiumBridge
+        https://bugs.webkit.org/show_bug.cgi?id=50285
+
+        Test by loading "about:histograms" after navigating to accelerated pages.
+
+        * platform/chromium/ChromiumBridge.h: api update.
+
 2010-12-02  Andras Becsi  <abecsi@webkit.org>
 

trunk/WebCore/platform/chromium/ChromiumBridge.h

@@ -240 +240 @@
         static void decrementStatsCounter(const char* name);
         static void incrementStatsCounter(const char* name);
+        static void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount);
+        static void histogramEnumeration(const char* name, int sample, int boundaryValue);
 
         // Sudden Termination

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-12-02  Vincent Scheib  <scheib@chromium.org>
+
+        Reviewed by Darin Fisher.
+
+        [chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
+        https://bugs.webkit.org/show_bug.cgi?id=50285
+
+        Test by loading "about:histograms" after navigating to accelerated pages.
+
+        * public/WebKitClient.h:
+        (WebKit::WebKitClient::histogramCustomCounts): api update.
+        (WebKit::WebKitClient::histogramEnumeration): api update.
+        * src/ChromiumBridge.cpp:
+        (WebCore::ChromiumBridge::histogramCustomCounts): api update.
+        (WebCore::ChromiumBridge::histogramEnumeration): api update.
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.
+
 2010-12-01  Jia Pu  <jpu@apple.com>
 

trunk/WebKit/chromium/public/WebKitClient.h

@@ -211 +211 @@
     virtual void traceEventEnd(const char* name, void* id, const char* extra) { }
 
-    // Generic callback for reporting histogram data. Range is identified by the min, max pair.
-    // By default, histogram is exponential, so that min=1, max=1000000, bucketCount=50 would do. Setting
-    // linear to true would require bucket count to cover whole min-max range.
-    virtual void histogramCounts(const WebString& name, int sample, int min, int max, int bucketCount, bool linear) { }
+    // Callbacks for reporting histogram data.
+    // CustomCounts histogram has exponential bucket sizes, so that min=1, max=1000000, bucketCount=50 would do.
+    virtual void histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount) { }
+    // Enumeration histogram buckets are linear, boundaryValue should be larger than any possible sample value.
+    virtual void histogramEnumeration(const char* name, int sample, int boundaryValue) { }
 
 

trunk/WebKit/chromium/src/ChromiumBridge.cpp

@@ -680 +680 @@
 }
 
+void ChromiumBridge::histogramCustomCounts(const char* name, int sample, int min, int max, int bucketCount)
+{
+    webKitClient()->histogramCustomCounts(name, sample, min, max, bucketCount);
+}
+
+void ChromiumBridge::histogramEnumeration(const char* name, int sample, int boundaryValue)
+{
+    webKitClient()->histogramEnumeration(name, sample, boundaryValue);
+}
+
 // Sudden Termination ---------------------------------------------------------
 

trunk/WebKit/chromium/src/WebViewImpl.cpp

@@ -36 +36 @@
 #include "BackForwardListImpl.h"
 #include "Chrome.h"
+#include "ChromiumBridge.h"
 #include "ColorSpace.h"
 #include "CompositionUnderlineVectorBuilder.h"
@@ -2375 +2376 @@
 void WebViewImpl::setIsAcceleratedCompositingActive(bool active)
 {
+    ChromiumBridge::histogramEnumeration("GPU.setIsAcceleratedCompositingActive", active * 2 + m_isAcceleratedCompositingActive, 4);
+
     if (m_isAcceleratedCompositingActive == active)
         return;