Changeset 73143 in webkit

Timestamp:

Dec 2, 2010 9:39:26 AM (13 years ago)

Author:

sullivan@apple.com

Message:

Slightly speculative fix for:

Reviewed by Adam Roben.

<rdar://problem/8712674>
<​https://bugs.webkit.org/show_bug.cgi?id=50393>
setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]

• Panels/WebAuthenticationPanel.m:

(-[WebAuthenticationPanel setUpForChallenge:]):
If the realm is nil, use @"" instead.

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Panels/WebAuthenticationPanel.m (modified) (1 diff)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2010-12-02  John Sullivan  <sullivan@apple.com>
+
+        Reviewed by Adam Roben.
+        
+        Slightly speculative fix for:
+
+        <rdar://problem/8712674>
+        <https://bugs.webkit.org/show_bug.cgi?id=50393>
+        setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]        
+
+        * Panels/WebAuthenticationPanel.m:
+        (-[WebAuthenticationPanel setUpForChallenge:]):
+        If the realm is nil, use @"" instead.
+
 2010-12-01  Jia Pu  <jpu@apple.com>
 

trunk/WebKit/mac/Panels/WebAuthenticationPanel.m

@@ -130 +130 @@
 
     NSString *realm = [space realm];
+    if (!realm)
+        realm = @"";
     NSString *message;