Changeset 73258 in webkit


Ignore:
Timestamp:
Dec 3, 2010 3:14:32 AM (13 years ago)
Author:
Nikolas Zimmermann
Message:

2010-12-03 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

1336 files in WebCore rebuild when you touch SVGNames
​https://bugs.webkit.org/show_bug.cgi?id=42025

Remove global SVGNames.h dependency, as SVGAnimatedPropertyMacros.h included it.
This requires to add the SVGNames.h include to lots of cpp files.

No functional changes, thus no new tests.

  • css/CSSCursorImageValue.cpp:
  • css/CSSFontFaceSource.cpp:
  • dom/Node.cpp:
  • loader/cache/CachedFont.cpp:
  • rendering/RenderSVGResourceClipper.cpp:
  • rendering/RenderSVGResourceFilter.cpp:
  • rendering/RenderSVGTransformableContainer.cpp:
  • rendering/RenderSVGViewportContainer.cpp:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/SVGResources.cpp:
  • rendering/svg/RenderSVGTextPath.cpp:
  • rendering/svg/SVGRootInlineBox.cpp:
  • svg/SVGAnimateElement.cpp:
  • svg/SVGAnimateMotionElement.cpp:
  • svg/SVGAnimateTransformElement.cpp:
  • svg/SVGDefsElement.cpp:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFont.cpp:
  • svg/SVGGElement.cpp:
  • svg/SVGImageElement.cpp:
  • svg/SVGLength.cpp:
  • svg/SVGMPathElement.cpp:
  • svg/SVGPathElement.cpp:
  • svg/SVGPathSegList.cpp:
  • svg/SVGStyledTransformableElement.cpp:
  • svg/SVGSymbolElement.cpp:
  • svg/SVGTextContentElement.cpp:
  • svg/SVGTextElement.cpp:
  • svg/SVGTextPathElement.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGViewSpec.cpp:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/properties/SVGAnimatedPropertyMacros.h:
  • svg/properties/SVGPathSegListPropertyTearOff.cpp:
Location:
trunk/WebCore
Files:
41 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r73257 r73258  
     12010-12-03  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        1336 files in WebCore rebuild when you touch SVGNames
     6        https://bugs.webkit.org/show_bug.cgi?id=42025
     7
     8        Remove global SVGNames.h dependency, as SVGAnimatedPropertyMacros.h included it.
     9        This requires to add the SVGNames.h include to lots of cpp files.
     10
     11        No functional changes, thus no new tests.
     12
     13        * css/CSSCursorImageValue.cpp:
     14        * css/CSSFontFaceSource.cpp:
     15        * dom/Node.cpp:
     16        * loader/cache/CachedFont.cpp:
     17        * rendering/RenderSVGResourceClipper.cpp:
     18        * rendering/RenderSVGResourceFilter.cpp:
     19        * rendering/RenderSVGTransformableContainer.cpp:
     20        * rendering/RenderSVGViewportContainer.cpp:
     21        * rendering/SVGRenderTreeAsText.cpp:
     22        * rendering/SVGResources.cpp:
     23        * rendering/svg/RenderSVGTextPath.cpp:
     24        * rendering/svg/SVGRootInlineBox.cpp:
     25        * svg/SVGAnimateElement.cpp:
     26        * svg/SVGAnimateMotionElement.cpp:
     27        * svg/SVGAnimateTransformElement.cpp:
     28        * svg/SVGDefsElement.cpp:
     29        * svg/SVGFEBlendElement.cpp:
     30        * svg/SVGFEDisplacementMapElement.cpp:
     31        * svg/SVGFEMergeElement.cpp:
     32        * svg/SVGFEMergeNodeElement.cpp:
     33        * svg/SVGFEOffsetElement.cpp:
     34        * svg/SVGFETileElement.cpp:
     35        * svg/SVGFETurbulenceElement.cpp:
     36        * svg/SVGFont.cpp:
     37        * svg/SVGGElement.cpp:
     38        * svg/SVGImageElement.cpp:
     39        * svg/SVGLength.cpp:
     40        * svg/SVGMPathElement.cpp:
     41        * svg/SVGPathElement.cpp:
     42        * svg/SVGPathSegList.cpp:
     43        * svg/SVGStyledTransformableElement.cpp:
     44        * svg/SVGSymbolElement.cpp:
     45        * svg/SVGTextContentElement.cpp:
     46        * svg/SVGTextElement.cpp:
     47        * svg/SVGTextPathElement.cpp:
     48        * svg/SVGUseElement.cpp:
     49        * svg/SVGViewSpec.cpp:
     50        * svg/animation/SMILTimeContainer.cpp:
     51        * svg/properties/SVGAnimatedPropertyMacros.h:
     52        * svg/properties/SVGPathSegListPropertyTearOff.cpp:
     53
    1542010-12-02  Philippe Normand  <pnormand@igalia.com>
    255

  • trunk/WebCore/css/CSSCursorImageValue.cpp

    r71503 r73258  
    3131#if ENABLE(SVG)
    3232#include "SVGCursorElement.h"
     33#include "SVGNames.h"
    3334#include "SVGURIReference.h"
    3435#endif

  • trunk/WebCore/css/CSSFontFaceSource.cpp

    r71979 r73258  
    3838#if ENABLE(SVG_FONTS)
    3939#include "FontCustomPlatformData.h"
    40 #include "HTMLNames.h"
    4140#include "SVGFontData.h"
    4241#include "SVGFontElement.h"
    4342#include "SVGFontFaceElement.h"
     43#include "SVGNames.h"
    4444#include "SVGURIReference.h"
    4545#endif

  • trunk/WebCore/dom/Node.cpp

    r72783 r73258  
    9898#if ENABLE(SVG)
    9999#include "SVGElementInstance.h"
     100#include "SVGNames.h"
    100101#include "SVGUseElement.h"
    101102#endif

  • trunk/WebCore/loader/cache/CachedFont.cpp

    r72230 r73258  
    3232#endif
    3333
    34 #include "MemoryCache.h"
    3534#include "CachedResourceClient.h"
    3635#include "CachedResourceClientWalker.h"
    3736#include "FontPlatformData.h"
     37#include "MemoryCache.h"
    3838#include "SharedBuffer.h"
    3939#include "TextResourceDecoder.h"
    … …  
    4646
    4747#if ENABLE(SVG_FONTS)
    48 #include "HTMLNames.h"
    4948#include "NodeList.h"
    5049#include "SVGElement.h"
    5150#include "SVGFontElement.h"
    5251#include "SVGGElement.h"
     52#include "SVGNames.h"
    5353#endif
    5454

  • trunk/WebCore/rendering/RenderSVGResourceClipper.cpp

    r72926 r73258  
    3939#include "SVGElement.h"
    4040#include "SVGImageBufferTools.h"
     41#include "SVGNames.h"
    4142#include "SVGRenderSupport.h"
    4243#include "SVGResources.h"

  • trunk/WebCore/rendering/RenderSVGResourceFilter.cpp

    r72926 r73258  
    4242#include "SVGFilterPrimitiveStandardAttributes.h"
    4343#include "SVGImageBufferTools.h"
     44#include "SVGNames.h"
    4445#include "SVGStyledElement.h"
    4546#include "SVGUnitTypes.h"

  • trunk/WebCore/rendering/RenderSVGTransformableContainer.cpp

    r66598 r73258  
    2525#include "RenderSVGTransformableContainer.h"
    2626
     27#include "SVGNames.h"
    2728#include "SVGShadowTreeElements.h"
    2829#include "SVGStyledTransformableElement.h"

  • trunk/WebCore/rendering/RenderSVGViewportContainer.cpp

    r66598 r73258  
    2929#include "GraphicsContext.h"
    3030#include "RenderView.h"
     31#include "SVGNames.h"
    3132#include "SVGSVGElement.h"
    3233

  • trunk/WebCore/rendering/SVGRenderTreeAsText.cpp

    r72474 r73258  
    6363#include "SVGLineElement.h"
    6464#include "SVGLinearGradientElement.h"
     65#include "SVGNames.h"
    6566#include "SVGPathElement.h"
    6667#include "SVGPathParserFactory.h"

  • trunk/WebCore/rendering/SVGResources.cpp

    r69927 r73258  
    2828#include "SVGFilterElement.h"
    2929#include "SVGGradientElement.h"
     30#include "SVGNames.h"
    3031#include "SVGPaint.h"
    3132#include "SVGPatternElement.h"

  • trunk/WebCore/rendering/svg/RenderSVGTextPath.cpp

    r69517 r73258  
    2929#include "RenderBlock.h"
    3030#include "SVGInlineTextBox.h"
     31#include "SVGNames.h"
    3132#include "SVGPathElement.h"
    3233#include "SVGRootInlineBox.h"

  • trunk/WebCore/rendering/svg/SVGRootInlineBox.cpp

    r69228 r73258  
    3131#include "SVGInlineFlowBox.h"
    3232#include "SVGInlineTextBox.h"
     33#include "SVGNames.h"
    3334#include "SVGRenderSupport.h"
    3435#include "SVGTextPositioningElement.h"

  • trunk/WebCore/svg/SVGAnimateElement.cpp

    r71512 r73258  
    2121
    2222#include "config.h"
     23
    2324#if ENABLE(SVG) && ENABLE(SVG_ANIMATION)
    2425#include "SVGAnimateElement.h"
    … …  
    2728#include "FloatConversion.h"
    2829#include "SVGColor.h"
     30#include "SVGNames.h"
    2931#include "SVGParserUtilities.h"
    3032#include "SVGPathParserFactory.h"
    3133#include "SVGPathSegList.h"
    3234#include "SVGPointList.h"
    33 #include <math.h>
    3435
    3536using namespace std;

  • trunk/WebCore/svg/SVGAnimateMotionElement.cpp

    r69517 r73258  
    3030#include "SVGElementInstance.h"
    3131#include "SVGMPathElement.h"
     32#include "SVGNames.h"
    3233#include "SVGParserUtilities.h"
    3334#include "SVGPathParserFactory.h"

  • trunk/WebCore/svg/SVGAnimateTransformElement.cpp

    r71802 r73258  
    3333#include "SVGElementInstance.h"
    3434#include "SVGGradientElement.h"
     35#include "SVGNames.h"
    3536#include "SVGParserUtilities.h"
    3637#include "SVGSVGElement.h"

  • trunk/WebCore/svg/SVGDefsElement.cpp

    r73254 r73258  
    2525
    2626#include "RenderSVGHiddenContainer.h"
     27#include "SVGNames.h"
    2728
    2829namespace WebCore {

  • trunk/WebCore/svg/SVGFEBlendElement.cpp

    r73130 r73258  
    2525
    2626#include "Attribute.h"
     27#include "SVGNames.h"
    2728
    2829namespace WebCore {

  • trunk/WebCore/svg/SVGFEDisplacementMapElement.cpp

    r73130 r73258  
    2424
    2525#include "Attribute.h"
     26#include "SVGNames.h"
    2627
    2728namespace WebCore {

  • trunk/WebCore/svg/SVGFEMergeElement.cpp

    r72474 r73258  
    2525
    2626#include "SVGFEMergeNodeElement.h"
     27#include "SVGNames.h"
    2728
    2829namespace WebCore {

  • trunk/WebCore/svg/SVGFEMergeNodeElement.cpp

    r73130 r73258  
    2828#include "RenderSVGResource.h"
    2929#include "SVGFilterElement.h"
     30#include "SVGNames.h"
    3031
    3132namespace WebCore {

  • trunk/WebCore/svg/SVGFEOffsetElement.cpp

    r73130 r73258  
    2424#include "SVGFEOffsetElement.h"
    2525
    26 #include "Attr.h"
     26#include "Attribute.h"
     27#include "SVGNames.h"
    2728
    2829namespace WebCore {

  • trunk/WebCore/svg/SVGFETileElement.cpp

    r73130 r73258  
    2424#include "SVGFETileElement.h"
    2525
    26 #include "Attr.h"
     26#include "Attribute.h"
     27#include "SVGNames.h"
    2728#include "SVGRenderStyle.h"
    2829

  • trunk/WebCore/svg/SVGFETurbulenceElement.cpp

    r73254 r73258  
    2525
    2626#include "Attribute.h"
     27#include "SVGNames.h"
    2728#include "SVGParserUtilities.h"
    2829

  • trunk/WebCore/svg/SVGFont.cpp

    r72926 r73258  
    3636#include "SVGFontFaceElement.h"
    3737#include "SVGMissingGlyphElement.h"
     38#include "SVGNames.h"
    3839#include "XMLNames.h"
    3940

  • trunk/WebCore/svg/SVGGElement.cpp

    r73254 r73258  
    2727#include "RenderSVGResource.h"
    2828#include "RenderSVGTransformableContainer.h"
     29#include "SVGNames.h"
    2930
    3031namespace WebCore {

  • trunk/WebCore/svg/SVGImageElement.cpp

    r73254 r73258  
    3030#include "RenderSVGImage.h"
    3131#include "RenderSVGResource.h"
    32 #include "SVGDocument.h"
    33 #include "SVGLength.h"
    34 #include "SVGPreserveAspectRatio.h"
     32#include "SVGNames.h"
    3533#include "SVGSVGElement.h"
    3634#include "XLinkNames.h"

  • trunk/WebCore/svg/SVGLength.cpp

    r72259 r73258  
    3030#include "RenderObject.h"
    3131#include "RenderView.h"
     32#include "SVGNames.h"
    3233#include "SVGParserUtilities.h"
    3334#include "SVGSVGElement.h"

  • trunk/WebCore/svg/SVGMPathElement.cpp

    r73254 r73258  
    2424
    2525#include "Document.h"
     26#include "SVGNames.h"
    2627#include "SVGPathElement.h"
    2728

  • trunk/WebCore/svg/SVGPathElement.cpp

    r73254 r73258  
    2727#include "RenderSVGPath.h"
    2828#include "RenderSVGResource.h"
     29#include "SVGNames.h"
    2930#include "SVGPathParserFactory.h"
    3031#include "SVGPathSegArc.h"

  • trunk/WebCore/svg/SVGPathSegList.cpp

    r72381 r73258  
    2626#include "SVGPathSegList.h"
    2727
     28#include "SVGNames.h"
    2829#include "SVGPathElement.h"
    2930#include "SVGPathParserFactory.h"

  • trunk/WebCore/svg/SVGStyledTransformableElement.cpp

    r73020 r73258  
    2525
    2626#include "AffineTransform.h"
    27 #include "Attr.h"
     27#include "Attribute.h"
    2828#include "RenderSVGPath.h"
    29 #include "SVGDocument.h"
    30 #include "SVGStyledElement.h"
    31 #include "SVGTransformList.h"
     29#include "SVGNames.h"
    3230
    3331namespace WebCore {

  • trunk/WebCore/svg/SVGSymbolElement.cpp

    r73254 r73258  
    2525
    2626#include "SVGFitToViewBox.h"
     27#include "SVGNames.h"
    2728
    2829namespace WebCore {

  • trunk/WebCore/svg/SVGTextContentElement.cpp

    r73254 r73258  
    2828#include "Frame.h"
    2929#include "RenderObject.h"
     30#include "SVGNames.h"
    3031#include "SVGTextQuery.h"
    3132#include "SelectionController.h"

  • trunk/WebCore/svg/SVGTextElement.cpp

    r73020 r73258  
    2929#include "RenderSVGResource.h"
    3030#include "RenderSVGText.h"
    31 #include "SVGLengthList.h"
     31#include "SVGNames.h"
    3232#include "SVGRenderStyle.h"
    3333#include "SVGTSpanElement.h"
    34 #include "SVGTransformList.h"
    3534
    3635namespace WebCore {

  • trunk/WebCore/svg/SVGTextPathElement.cpp

    r73130 r73258  
    2525
    2626#include "Attribute.h"
     27#include "SVGNames.h"
    2728#include "RenderSVGResource.h"
    2829#include "RenderSVGTextPath.h"

  • trunk/WebCore/svg/SVGUseElement.cpp

    r73254 r73258  
    3838#include "SVGElementInstanceList.h"
    3939#include "SVGGElement.h"
    40 #include "SVGLength.h"
    41 #include "SVGPreserveAspectRatio.h"
     40#include "SVGNames.h"
    4241#include "SVGSMILElement.h"
    4342#include "SVGSVGElement.h"

  • trunk/WebCore/svg/SVGViewSpec.cpp

    r73254 r73258  
    2424
    2525#include "Document.h"
     26#include "SVGNames.h"
    2627#include "SVGParserUtilities.h"
    27 #include "SVGPreserveAspectRatio.h"
    2828#include "SVGSVGElement.h"
    2929#include "SVGTransformable.h"

  • trunk/WebCore/svg/animation/SMILTimeContainer.cpp

    r71686 r73258  
    2828
    2929#if ENABLE(SVG)
    30 
    3130#include "CSSComputedStyleDeclaration.h"
    3231#include "CSSParser.h"
    3332#include "Document.h"
    3433#include "SVGAnimationElement.h"
     34#include "SVGNames.h"
    3535#include "SVGSMILElement.h"
    3636#include "SVGSVGElement.h"

  • trunk/WebCore/svg/properties/SVGAnimatedPropertyMacros.h

    r73254 r73258  
    2525#if ENABLE(SVG)
    2626#include "SVGAnimatedPropertySynchronizer.h"
    27 #include "SVGNames.h" // FIXME: Temporary hack, until we expand the macros in all files, so we don't need a global SVGNames.h include
    2827#include "SVGPropertyTraits.h"
    2928

  • trunk/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp

    r72381 r73258  
    2424
    2525#include "SVGAnimatedPathSegListPropertyTearOff.h"
     26#include "SVGNames.h"
    2627#include "SVGPathElement.h"
    2728#include "SVGPathSegWithContext.h"
Note: See TracChangeset for help on using the changeset viewer.