Changeset 73383 in webkit


Ignore:
Timestamp:
Dec 6, 2010 11:59:40 AM (13 years ago)
Author:
andersca@apple.com
Message:

REGERSSION (r73310?): Contents of <select> popup menus are upside-down on Windows
https://bugs.webkit.org/show_bug.cgi?id=50544
<rdar://problem/8732336>

Reviewed by Dan Bernstein.

  • Shared/BackingStore.cpp:
  • Shared/BackingStore.h:
  • Shared/cairo/BackingStoreCairo.cpp:

Remove BackingStore::createFlippedGraphicsContext.

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:

(WebKit::WebPopupMenu::setUpPlatformData):
Don't create a flipped graphics context.

Location:
trunk/WebKit2
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit2/ChangeLog

    r73382 r73383  
     12010-12-06  Anders Carlsson  <andersca@apple.com>
     2
     3        Reviewed by Dan Bernstein.
     4
     5        REGERSSION (r73310?): Contents of <select> popup menus are upside-down on Windows
     6        https://bugs.webkit.org/show_bug.cgi?id=50544
     7        <rdar://problem/8732336>
     8
     9        * Shared/BackingStore.cpp:
     10        * Shared/BackingStore.h:
     11        * Shared/cairo/BackingStoreCairo.cpp:
     12        Remove BackingStore::createFlippedGraphicsContext.
     13
     14        * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
     15        (WebKit::WebPopupMenu::setUpPlatformData):
     16        Don't create a flipped graphics context.
     17
    1182010-12-06  Anders Carlsson  <andersca@apple.com>
    219
  • trunk/WebKit2/Shared/BackingStore.cpp

    r73318 r73383  
    126126}
    127127
    128 PassOwnPtr<GraphicsContext> BackingStore::createFlippedGraphicsContext()
    129 {
    130     OwnPtr<GraphicsContext> graphicsContext = createGraphicsContext();
    131 
    132     // Flip the coordinate system.
    133     graphicsContext->translate(0, m_size.height());
    134     graphicsContext->scale(FloatSize(1, -1));
    135 
    136     return graphicsContext.release();
    137 }
    138    
    139128} // namespace WebKit
  • trunk/WebKit2/Shared/BackingStore.h

    r73318 r73383  
    6363    // Create a graphics context that can be used to paint into the backing store.
    6464    PassOwnPtr<WebCore::GraphicsContext> createGraphicsContext();
    65     PassOwnPtr<WebCore::GraphicsContext> createFlippedGraphicsContext();
    6665
    6766    // Paint the backing store into the given context.
  • trunk/WebKit2/Shared/cairo/BackingStoreCairo.cpp

    r71863 r73383  
    3939}
    4040
    41 PassOwnPtr<GraphicsContext> BackingStore::createFlippedGraphicsContext()
    42 {
    43     notImplemented();
    44     return 0;
    45 }
    46 
    4741void BackingStore::paint(GraphicsContext&, const IntPoint&, const IntRect&)
    4842{
  • trunk/WebKit2/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp

    r71640 r73383  
    7979    data.m_selectedBackingStore = BackingStore::createSharable(data.m_backingStoreSize);
    8080
    81     OwnPtr<GraphicsContext> notSelectedBackingStoreContext = data.m_notSelectedBackingStore->createFlippedGraphicsContext();
    82     OwnPtr<GraphicsContext> selectedBackingStoreContext = data.m_selectedBackingStore->createFlippedGraphicsContext();
     81    OwnPtr<GraphicsContext> notSelectedBackingStoreContext = data.m_notSelectedBackingStore->createGraphicsContext();
     82    OwnPtr<GraphicsContext> selectedBackingStoreContext = data.m_selectedBackingStore->createGraphicsContext();
    8383
    8484    Color activeOptionBackgroundColor = RenderTheme::defaultTheme()->activeListBoxSelectionBackgroundColor();
Note: See TracChangeset for help on using the changeset viewer.