Changeset 73389 in webkit


Ignore:
Timestamp:
Dec 6, 2010 12:39:50 PM (13 years ago)
Author:
tony@chromium.org
Message:

2010-12-06 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] fix an assert hit in DRT
https://bugs.webkit.org/show_bug.cgi?id=50575

This class uses WTF's RefPtr, but expects chrome's base::RefPtr
semantics.

Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
(third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
WTF::RefCountedBase::ref()).

  • DumpRenderTree/chromium/TestWebWorker.h: (TestWebWorker::TestWebWorker):
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r73384 r73389  
     12010-12-06  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Ojan Vafai.
     4
     5        [chromium] fix an assert hit in DRT
     6        https://bugs.webkit.org/show_bug.cgi?id=50575
     7
     8        This class uses WTF's RefPtr, but expects chrome's base::RefPtr
     9        semantics.
     10
     11        Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
     12        (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
     13        WTF::RefCountedBase::ref()).
     14
     15        * DumpRenderTree/chromium/TestWebWorker.h:
     16        (TestWebWorker::TestWebWorker):
     17
    1182010-12-02  Ojan Vafai  <ojan@chromium.org>
    219
  • trunk/WebKitTools/DumpRenderTree/chromium/TestWebWorker.h

    r70064 r73389  
    4949    TestWebWorker()
    5050    {
     51        // This class expects refcounting semantics like those found in
     52        // Chromium's base::RefCounted, so it's OK to call ref() directly.
     53        relaxAdoptionRequirement();
    5154        ref();
    5255        // The initial counter value should be 2. One for a worker object,
Note: See TracChangeset for help on using the changeset viewer.