Changeset 73700 in webkit

Timestamp:

Dec 10, 2010 2:25:55 AM (13 years ago)

Author:

Philippe Normand

Message:

2010-12-10 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GStreamer] data: source could also support non-base64 encoded URIs
​https://bugs.webkit.org/show_bug.cgi?id=30007

Removed our ancient implementation of dataurisrc. We should now
use the one in gst-plugins-bad which is more mature.

• GNUmakefile.am:
• platform/graphics/gstreamer/DataSourceGStreamer.cpp: Removed.
• platform/graphics/gstreamer/DataSourceGStreamer.h: Removed.
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::doGstInit):

LayoutTests:

Reviewed by Gustavo Noronha Silva.

[GStreamer] data: source could also support non-base64 encoded URIs
​https://bugs.webkit.org/show_bug.cgi?id=30007

• platform/gtk/Skipped: Unskipped media/audio-data-url.html. It should now be much more reliable on the bots running latest GStreamer versions.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/GNUmakefile.am (modified) (1 diff)
• WebCore/platform/graphics/gstreamer/DataSourceGStreamer.cpp (deleted)
• WebCore/platform/graphics/gstreamer/DataSourceGStreamer.h (deleted)
• WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-10  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GStreamer] data: source could also support non-base64 encoded URIs
+        https://bugs.webkit.org/show_bug.cgi?id=30007
+
+        * platform/gtk/Skipped: Unskipped media/audio-data-url.html. It
+        should now be much more reliable on the bots running latest
+        GStreamer versions.
+
 2010-12-10  Hans Wennborg  <hans@chromium.org>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -5020 +5020 @@
 plugins/update-widgets-crash.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=37564
-media/audio-data-url.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=37572
 plugins/open-and-close-window-with-plugin.html

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-10  Philippe Normand  <pnormand@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GStreamer] data: source could also support non-base64 encoded URIs
+        https://bugs.webkit.org/show_bug.cgi?id=30007
+
+        Removed our ancient implementation of dataurisrc. We should now
+        use the one in gst-plugins-bad which is more mature.
+
+        * GNUmakefile.am:
+        * platform/graphics/gstreamer/DataSourceGStreamer.cpp: Removed.
+        * platform/graphics/gstreamer/DataSourceGStreamer.h: Removed.
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::doGstInit):
+
 2010-12-10  Zoltan Herczeg  <zherczeg@webkit.org>
 

trunk/WebCore/GNUmakefile.am

@@ -3636 +3636 @@
         WebCore/platform/graphics/cairo/RefPtrCairo.h \
         WebCore/platform/graphics/cairo/TransformationMatrixCairo.cpp \
-        WebCore/platform/graphics/gstreamer/DataSourceGStreamer.cpp \
-        WebCore/platform/graphics/gstreamer/DataSourceGStreamer.h \
         WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.cpp \
         WebCore/platform/graphics/gstreamer/GOwnPtrGStreamer.h \

trunk/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -28 +28 @@
 
 #include "ColorSpace.h"
-#include "DataSourceGStreamer.h"
 #include "Document.h"
 #include "Frame.h"
@@ -284 +283 @@
         GOwnPtr<GError> error;
         gstInitialized = gst_init_check(0, 0, &error.outPtr());
-        if (!gstInitialized) {
+        if (!gstInitialized)
             LOG_VERBOSE(Media, "Could not initialize GStreamer: %s",
                         error ? error->message : "unknown error occurred");
-        } else {
-            gst_element_register(0, "webkitmediasrc", GST_RANK_PRIMARY,
-                                 WEBKIT_TYPE_DATA_SRC);
+        else
             gst_element_register(0, "webkitwebsrc", GST_RANK_PRIMARY + 100,
                                  WEBKIT_TYPE_WEB_SRC);
-        }
-
     }
     return gstInitialized;