Changeset 73735 in webkit


Ignore:
Timestamp:
Dec 10, 2010 9:16:17 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2010-12-10 Joone Hur <​joone@kldp.org>

Reviewed by Xan Lopez.

[GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
​https://bugs.webkit.org/show_bug.cgi?id=50808

Unskipping the following test cases:
userscripts/mixed-case-stylesheet.html
userscripts/simple-stylesheet.html
userscripts/user-style-all-frames.html

  • platform/gtk/Skipped:

2010-12-10 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Remove unnecessary variable names from DumpRenderTreeSupportGtk
​https://bugs.webkit.org/show_bug.cgi?id=50815

There were some unnecessary variable names in DumpRenderTreeSupportGtk,
so remove them.

  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.

2010-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Ojan Vafai.

webkit-patch: not possible to use build-and-test with local commits
​https://bugs.webkit.org/show_bug.cgi?id=33378

Make --no-clean not even check if we have local commits.
It's unclear to me why the code was originally written this way.
I was unable to dig up a reason from svn history.

  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r73732 r73735  
     12010-12-10  Joone Hur  <joone@kldp.org>
     2
     3        Reviewed by Xan Lopez.
     4
     5        [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
     6        https://bugs.webkit.org/show_bug.cgi?id=50808
     7
     8        Unskipping the following test cases:
     9        userscripts/mixed-case-stylesheet.html
     10        userscripts/simple-stylesheet.html
     11        userscripts/user-style-all-frames.html
     12
     13        * platform/gtk/Skipped:
     14
    1152010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
    216

  • trunk/LayoutTests/platform/gtk/Skipped

    r73732 r73735  
    47024702
    47034703# No User Scripts
    4704 userscripts
     4704userscripts/script-not-run-for-fragments.html
     4705userscripts/script-run-at-end.html
     4706userscripts/script-run-at-start.html
     4707userscripts/user-script-all-frames.html
     4708userscripts/user-script-audio-document.html
     4709userscripts/user-script-image-document.html
     4710userscripts/user-script-plugin-document.html
     4711userscripts/user-script-top-frame-only.html
     4712userscripts/user-script-video-document.html
     4713userscripts/user-style-top-frame-only.html
    47054714
    47064715# XHR sends sometimes yield null bytes sent instead of 0.

  • trunk/WebKit/gtk/ChangeLog

    r73727 r73735  
    1010
    1111        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Do it.
     12
     132010-12-10  Joone Hur  <joone@kldp.org>
     14
     15        Reviewed by Xan Lopez.
     16
     17        [GTK] Unskipping some test cases in /userscripts dependent on addUserStyleSheet
     18        https://bugs.webkit.org/show_bug.cgi?id=50808
     19
     20        Unskipping the following test cases:
     21        userscripts/mixed-case-stylesheet.html
     22        userscripts/simple-stylesheet.html
     23        userscripts/user-style-all-frames.html
     24
     25        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
     26        (DumpRenderTreeSupportGtk::addUserStyleSheet): Added "bool allFrames" parameter.
     27        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
    1228
    13292010-12-10  Joone Hur  <joone@kldp.org>

  • trunk/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

    r73714 r73735  
    310310 *
    311311 */
    312 void DumpRenderTreeSupportGtk::addUserStyleSheet(WebKitWebFrame* frame, const char* sourceCode)
     312void DumpRenderTreeSupportGtk::addUserStyleSheet(WebKitWebFrame* frame, const char* sourceCode, bool allFrames)
    313313{
    314314    g_return_if_fail(WEBKIT_IS_WEB_FRAME(frame));
    … …  
    320320    WebKitWebView* webView = getViewFromFrame(frame);
    321321    Page* page = core(webView);
    322     page->group().addUserStyleSheetToWorld(mainThreadNormalWorld(), sourceCode, KURL(), 0, 0, WebCore::InjectInAllFrames);
     322    page->group().addUserStyleSheetToWorld(mainThreadNormalWorld(), sourceCode, KURL(), 0, 0, allFrames ? InjectInAllFrames : InjectInTopFrameOnly);
    323323}
    324324

  • trunk/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

    r73727 r73735  
    5454    static bool isPageBoxVisible(WebKitWebFrame*, int pageNumber);
    5555    static WTF::CString pageSizeAndMarginsInPixels(WebKitWebFrame*, int pageNumber, int width, int height, int marginTop, int marginRight, int marginBottom, int marginLeft);
    56     static void addUserStyleSheet(WebKitWebFrame*, const char* sourceCode);
     56    static void addUserStyleSheet(WebKitWebFrame*, const char* sourceCode, bool allFrames);
    5757    static guint getPendingUnloadEventCount(WebKitWebFrame*);
    5858    static bool pauseAnimation(WebKitWebFrame*, const char* name, double time, const char* element);

  • trunk/WebKitTools/ChangeLog

    r73733 r73735  
    4141        * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
    4242        (WTR::WebView::WebView):
     43
     442010-12-10  Joone Hur  <joone@kldp.org>
     45
     46        Reviewed by Xan Lopez.
     47
     48        [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
     49        https://bugs.webkit.org/show_bug.cgi?id=50808
     50
     51        Unskipping the following test cases:
     52        userscripts/mixed-case-stylesheet.html
     53        userscripts/simple-stylesheet.html
     54        userscripts/user-style-all-frames.html
     55
     56        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     57        (LayoutTestController::addUserStyleSheet):
    4358
    44592010-12-10  Joone Hur  <joone@kldp.org>

  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r73714 r73735  
    717717{
    718718    GOwnPtr<gchar> sourceCode(JSStringCopyUTF8CString(source));
    719     DumpRenderTreeSupportGtk::addUserStyleSheet(mainFrame, sourceCode.get());
     719    DumpRenderTreeSupportGtk::addUserStyleSheet(mainFrame, sourceCode.get(), allFrames);
     720    // FIXME: needs more investigation why userscripts/user-style-top-frame-only.html fails when allFrames is false.
     721
    720722}
    721723
Note: See TracChangeset for help on using the changeset viewer.