Changeset 73970 in webkit

Timestamp:

Dec 13, 2010 3:02:47 PM (13 years ago)

Author:

bweinstein@apple.com

Message:

WebKit2: Leaks a WebView when opening/closing Web Inspector on Windows
​https://bugs.webkit.org/show_bug.cgi?id=50975
<rdar://problem/8763501>

Reviewed by Adam Roben.

Make m_inspectorView be a RefPtr<WebView>, instead of a WebView*.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): If we are on Windows, include WebView.h.

• UIProcess/WebInspectorProxy.h: Change the type of m_inspectorView to a RefPtr<WebView>.
• UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Remove the call to leakRef when creating the WebView.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebInspectorProxy.cpp (modified) (2 diffs)
• UIProcess/WebInspectorProxy.h (modified) (2 diffs)
• UIProcess/win/WebInspectorProxyWin.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-12-13  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Adam Roben.
+
+        WebKit2: Leaks a WebView when opening/closing Web Inspector on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=50975
+        <rdar://problem/8763501>
+        
+        Make m_inspectorView be a RefPtr<WebView>, instead of a WebView*.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::WebInspectorProxy): If we are on Windows, include WebView.h.
+        * UIProcess/WebInspectorProxy.h: Change the type of m_inspectorView to a RefPtr<WebView>.
+        * UIProcess/win/WebInspectorProxyWin.cpp:
+        (WebKit::WebInspectorProxy::platformCreateInspectorPage): Remove the call to leakRef when creating the WebView.
+
 2010-12-13  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKit2/UIProcess/WebInspectorProxy.cpp

@@ -34 +34 @@
 #include "WebPageGroup.h"
 
+#if PLATFORM(WIN)
+#include "WebView.h"
+#endif
+
 #define DISABLE_NOT_IMPLEMENTED_WARNINGS 1
 #include "NotImplemented.h"
@@ -56 +60 @@
 #if PLATFORM(WIN)
     , m_inspectorWindow(0)
-    , m_inspectorView(0)
 #endif
 {

trunk/WebKit2/UIProcess/WebInspectorProxy.h

@@ -33 +33 @@
 #include <wtf/Forward.h>
 #include <wtf/PassRefPtr.h>
+#include <wtf/RefPtr.h>
 
 #if PLATFORM(MAC)
@@ -148 +149 @@
 #elif PLATFORM(WIN)
     HWND m_inspectorWindow;
-    WebView* m_inspectorView;
+    RefPtr<WebView> m_inspectorView;
 #endif
 };

trunk/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp

@@ -153 +153 @@
 
     RECT emptyRect = {0};
-    m_inspectorView = WebView::createForAssociatedPage(emptyRect, m_page, inspectorPageGroup(), 0).leakRef();
+    m_inspectorView = WebView::createForAssociatedPage(emptyRect, m_page, inspectorPageGroup(), 0);
 
     return m_inspectorView->page();