Changeset 74089 in webkit


Ignore:
Timestamp:
Dec 14, 2010 6:09:13 PM (13 years ago)
Author:
morrita@google.com
Message:

2010-12-02 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix drawing of inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=41576

  • platform/chromium-win/fast/box-shadow/inset-expected.checksum:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:

2010-12-02 MORITA Hajime <​morrita@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Fix drawing of inset box shadows
​https://bugs.webkit.org/show_bug.cgi?id=41576

When clearing outside clipped path, the context contains unexpected transform.
Fixed to restore original state before the clear.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::clipPathAntiAliased): (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r74087 r74089  
     12010-12-02  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [chromium] Fix drawing of inset box shadows
     6        https://bugs.webkit.org/show_bug.cgi?id=41576
     7
     8        * platform/chromium-win/fast/box-shadow/inset-expected.checksum:
     9        * platform/chromium-win/fast/box-shadow/inset-expected.png:
     10
    1112010-12-14  Yael Aharon  <yael.aharon@nokia.com>
    212

  • trunk/LayoutTests/platform/chromium-win/fast/box-shadow/inset-expected.checksum

    r56264 r74089  
    1 099b9b1b37f7dc784445a53b9215d653
     1f6660780769f8736789850eaeccaddce

  • trunk/WebCore/ChangeLog

    r74086 r74089  
     12010-12-02  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        [chromium] Fix drawing of inset box shadows
     6        https://bugs.webkit.org/show_bug.cgi?id=41576
     7
     8        When clearing outside clipped path, the context contains unexpected transform.
     9        Fixed to restore original state before the clear.
     10
     11        * platform/graphics/skia/PlatformContextSkia.cpp:
     12        (WebCore::PlatformContextSkia::clipPathAntiAliased):
     13        (WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
     14
    1152010-12-14  Anders Carlsson  <andersca@apple.com>
    216

  • trunk/WebCore/platform/graphics/skia/PlatformContextSkia.cpp

    r73284 r74089  
    300300        SkRect bounds = clipPath.getBounds();
    301301        canvas()->saveLayerAlpha(&bounds, 255, static_cast<SkCanvas::SaveFlags>(SkCanvas::kHasAlphaLayer_SaveFlag | SkCanvas::kFullColorLayer_SaveFlag | SkCanvas::kClipToLayer_SaveFlag));
     302        // Guards state modification during clipped operations.
     303        // The state is popped in applyAntiAliasedClipPaths().
     304        canvas()->save();
    302305    }
    303306}
    … …  
    676679    // into the layer below and we end up with correct, anti-aliased clipping.
    677680
     681    m_canvas->restore();
     682
    678683    SkPaint paint;
    679684    paint.setXfermodeMode(SkXfermode::kClear_Mode);
Note: See TracChangeset for help on using the changeset viewer.