Changeset 74150 in webkit

Timestamp:

Dec 15, 2010 3:33:58 PM (13 years ago)

Author:

ojan@chromium.org

Message:

2010-12-15 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Barth.

fix goofups from r74142 and r74130
​https://bugs.webkit.org/show_bug.cgi?id=51146

Accidentally shrank the inline comment boxes and made
the toolbar not show up when there were image diffs.

• PrettyPatch/PrettyPatch.rb:
• code-review.js:

Location:

trunk/BugsSite

Files:

• ChangeLog (modified) (1 diff)
• PrettyPatch/PrettyPatch.rb (modified) (2 diffs)
• code-review.js (modified) (1 diff)

trunk/BugsSite/ChangeLog

@@ +1 @@
+2010-12-15  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        fix goofups from r74142 and r74130
+        https://bugs.webkit.org/show_bug.cgi?id=51146
+
+        Accidentally shrank the inline comment boxes and made
+        the toolbar not show up when there were image diffs.
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
 2010-12-14  Ojan Vafai  <ojan@chromium.org>
 

trunk/BugsSite/PrettyPatch/PrettyPatch.rb

@@ -208 +208 @@
 }
 
+.comment textarea {
+  height: 6em;
+}
+
+.overallComments textarea {
+  height: 2em;
+}
+
 .comment textarea, .overallComments textarea {
   display: block;
   width: 100%;
-  height: 2em;
 }
 
@@ -352 +359 @@
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=14"></script> 
+<script src="code-review.js?version=15"></script> 
 EOF
 

trunk/BugsSite/code-review.js

@@ -288 +288 @@
 
     var file_diff = files[file_name];
-    $('.context', file_diff).detach();
-
-    var expand_bar_index = 0;
 
     // Don't show the links to expand upwards/downwards if the patch starts/ends without context
     // lines, i.e. starts/ends with add/remove lines.
     var first_line = file_diff.querySelector('.Line');
+
+    // If there is no element with a "Line" class, then this is an image diff.
+    if (!first_line)
+      return;
+
+    $('.context', file_diff).detach();
+
+    var expand_bar_index = 0;
     if (!$(first_line).hasClass('add') && !$(first_line).hasClass('remove'))
       $('h1', file_diff).after(expandBarHtml(file_name, BELOW))