Changeset 74157 in webkit

Timestamp:

Dec 15, 2010 3:55:22 PM (13 years ago)

Author:

weinig@apple.com

Message:

Loading webkit.org over and over is slower in WebKit2 than WebKit1, looks like page is not cached
<rdar://problem/8774683>
​https://bugs.webkit.org/show_bug.cgi?id=51143

Reviewed by Brady Eidson.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canCachePage): Return true as long as we
are not a custom representation (eg. a PDF).
(WebKit::WebFrameLoaderClient::shouldCacheResponse): Always return true.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Enable the page cache.

Location:

trunk/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (modified) (2 diffs)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/WebKit2/ChangeLog

@@ +1 @@
+2010-12-15  Sam Weinig  <sam@webkit.org>
+
+        Reviewed by Brady Eidson.
+
+        Loading webkit.org over and over is slower in WebKit2 than WebKit1, looks like page is not cached
+        <rdar://problem/8774683>
+        https://bugs.webkit.org/show_bug.cgi?id=51143
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::canCachePage): Return true as long as we
+        are not a custom representation (eg. a PDF).
+        (WebKit::WebFrameLoaderClient::shouldCacheResponse): Always return true.
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences): Enable the page cache.
+
 2010-12-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

@@ -1067 +1067 @@
 bool WebFrameLoaderClient::canCachePage() const
 {
-    notImplemented();
-    return false;
+    // We cannot cache frames that have custom representations because they are
+    // rendered in the UIProcess. 
+    return !m_frameHasCustomRepresentation;
 }
 
@@ -1223 +1224 @@
 bool WebFrameLoaderClient::shouldCacheResponse(DocumentLoader*, unsigned long identifier, const ResourceResponse&, const unsigned char* data, unsigned long long length)
 {
+    return true;
+}
+
+#endif
+
+bool WebFrameLoaderClient::shouldUsePluginDocument(const String& /*mimeType*/) const
+{
     notImplemented();
     return false;
 }
 
-#endif
-
-bool WebFrameLoaderClient::shouldUsePluginDocument(const String& /*mimeType*/) const
-{
-    notImplemented();
-    return false;
-}
-
 PassRefPtr<FrameNetworkingContext> WebFrameLoaderClient::createNetworkingContext()
 {

trunk/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -982 +982 @@
     AbstractDatabase::setIsAvailable(store.getBoolValueForKey(WebPreferencesKey::databasesEnabledKey()));
 #endif
-    
+
+    settings->setUsesPageCache(true);
+
     platformPreferencesDidChange(store);
 }