Changeset 74173 in webkit

Timestamp:

Dec 15, 2010 10:14:21 PM (13 years ago)

Author:

Laszlo Gombos

Message:

2010-12-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antonio Gomes.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
​https://bugs.webkit.org/show_bug.cgi?id=46814

Change the test case according to the changes introduced by
r72603 and enable the test case.

• tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• tests/qwebpage/tst_qwebpage.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-12-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] Fix tst_QWebPage::geolocationRequestJS()
+        https://bugs.webkit.org/show_bug.cgi?id=46814
+
+        Change the test case according to the changes introduced by
+        r72603 and enable the test case.
+
+        * tests/qwebpage/tst_qwebpage.cpp:
+        (tst_QWebPage::geolocationRequestJS):
+
 2010-12-14  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
 

trunk/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

@@ -251 +251 @@
 void tst_QWebPage::geolocationRequestJS()
 {
-    /*
-      This test is disabled because it can only succeed if ENABLE(GEOLOCATION) is true.
-      The code needs to be updated when the API of requestPermissionFromUser is updated.
-    */
-    QSKIP("Test disabled as long as geolocation is disabled from the build.", SkipSingle);
-
     JSTestPage* newPage = new JSTestPage(m_view);
-    connect(newPage, SIGNAL(requestPermissionFromUser(QWebFrame*, QWebPage::Feature)), 
+    connect(newPage, SIGNAL(featurePermissionRequested(QWebFrame*, QWebPage::Feature)),
             newPage, SLOT(requestPermission(QWebFrame*, QWebPage::Feature)));