Changeset 74216 in webkit

Timestamp:

Dec 16, 2010 3:12:51 PM (13 years ago)

Author:

rniwa@webkit.org

Message:

2010-12-16 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Cameron Zwarich.

REGRESSION(r74172): 125 java tests fail on Mac
​https://bugs.webkit.org/show_bug.cgi?id=51214

The regression was caused by an incorrectly adding sizeof(struct fat_header)
to a pointer for uint32_t as supposed to uint8_t.

Fixed the bug by explicitly casting it to uint8_t* before the addition.

• Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage isNativeLibraryData:]):

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• Plugins/WebBasePluginPackage.mm (modified) (1 diff)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2010-12-16  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Cameron Zwarich.
+
+        REGRESSION(r74172): 125 java tests fail on Mac
+        https://bugs.webkit.org/show_bug.cgi?id=51214
+
+        The regression was caused by an incorrectly adding sizeof(struct fat_header)
+        to a pointer for uint32_t as supposed to uint8_t.
+
+        Fixed the bug by explicitly casting it to uint8_t* before the addition.
+
+        * Plugins/WebBasePluginPackage.mm:
+        (-[WebBasePluginPackage isNativeLibraryData:]):
+
 2010-12-15  Cameron Zwarich  <zwarich@apple.com>
 

trunk/WebKit/mac/Plugins/WebBasePluginPackage.mm

@@ -396 +396 @@
                 swapIntsInHeader(rawData.data(), rawData.size());
             
-            archs = (struct fat_arch*)(rawData.data() + sizeof(struct fat_header));            
+            archs = (struct fat_arch*)((uint8_t*)rawData.data() + sizeof(struct fat_header));            
             numArchs = ((struct fat_header *)rawData.data())->nfat_arch;