Changeset 74228 in webkit

Timestamp:

Dec 16, 2010, 7:28:51 PM (15 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-16 Yi Shen <​yi.4.shen@nokia.com>, Tor Arne Vestbo <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Carlson.

Provide an interface to require using fullscreen mediaplayer
​https://bugs.webkit.org/show_bug.cgi?id=51133

Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
to launch fullscreen video player for playing the html5 video. The
idea is that a browser vendor can specify this behavior through the
platform plugin or something else by using this interface.

No new tests because no client implements requiresFullscreenForVideoPlayback yet.

• html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState): (WebCore::HTMLMediaElement::exitFullscreen):
• page/Chrome.cpp: (WebCore::Chrome::requiresFullscreenForVideoPlayback):
• page/Chrome.h:
• page/ChromeClient.h: (WebCore::ChromeClient::requiresFullscreenForVideoPlayback):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (2 diffs)
• page/Chrome.cpp (modified) (1 diff)
• page/Chrome.h (modified) (1 diff)
• page/ChromeClient.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-16  Yi Shen  <yi.4.shen@nokia.com>, Tor Arne Vestbo <tor.arne.vestbo@nokia.com>
+
+        Reviewed by Eric Carlson.
+
+        Provide an interface to require using fullscreen mediaplayer
+        https://bugs.webkit.org/show_bug.cgi?id=51133
+
+        Add ChromeClient::requiresFullscreenForVideoPlayback to require webkit
+        to launch fullscreen video player for playing the html5 video. The 
+        idea is that a browser vendor can specify this behavior through the
+        platform plugin or something else by using this interface.
+
+        No new tests because no client implements requiresFullscreenForVideoPlayback yet.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::updatePlayState):
+        (WebCore::HTMLMediaElement::exitFullscreen):
+        * page/Chrome.cpp:
+        (WebCore::Chrome::requiresFullscreenForVideoPlayback):
+        * page/Chrome.h:
+        * page/ChromeClient.h:
+        (WebCore::ChromeClient::requiresFullscreenForVideoPlayback):
+
 2010-12-16  Steve Block  <steveblock@google.com>
 

trunk/WebCore/html/HTMLMediaElement.cpp

@@ -2110 +2110 @@
 
         if (playerPaused) {
+            if (document() && document()->page() && document()->page()->chrome()->requiresFullscreenForVideoPlayback() && !m_isFullscreen)
+                enterFullscreen();
+
             // Set rate before calling play in case the rate was set before the media engine was setup.
             // The media engine should just stash the rate since it isn't already playing.
@@ -2425 +2428 @@
     m_isFullscreen = false;
     if (document() && document()->page()) {
+        if (document()->page()->chrome()->requiresFullscreenForVideoPlayback())
+            pauseInternal();
         document()->page()->chrome()->client()->exitFullscreenForNode(this);
         scheduleEvent(eventNames().webkitendfullscreenEvent);

trunk/WebCore/page/Chrome.cpp

@@ -522 +522 @@
 #endif
 
+bool Chrome::requiresFullscreenForVideoPlayback()
+{
+    return m_client->requiresFullscreenForVideoPlayback();
+}
+
 } // namespace WebCore

trunk/WebCore/page/Chrome.h

@@ -150 +150 @@
         void dispatchViewportDataDidChange(const ViewportArguments&) const;
 
+        bool requiresFullscreenForVideoPlayback();
+
 #if PLATFORM(MAC)
         void focusNSView(NSView*);

trunk/WebCore/page/ChromeClient.h

@@ -257 +257 @@
         virtual void enterFullscreenForNode(Node*) { }
         virtual void exitFullscreenForNode(Node*) { }
+        virtual bool requiresFullscreenForVideoPlayback() { return false; } 
 
 #if ENABLE(FULLSCREEN_API)