Changeset 74609 in webkit
- Timestamp:
- Dec 23, 2010, 8:06:26 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 13 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r74608 r74609 1 2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com> 2 3 Reviewed by Adam Barth. 4 5 [Qt] User name/password stripped from URLs 6 https://bugs.webkit.org/show_bug.cgi?id=36232 7 8 Test authentication cases where a username but no password and 9 no username but a password is present. 10 11 * http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added. 12 * http/tests/xmlhttprequest/basic-auth-nopassword.html: Added. 13 * http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added. 14 * http/tests/xmlhttprequest/basic-auth-nouser.html: Added. 15 * http/tests/xmlhttprequest/resources/basic-auth-nouserpass/basic-auth-nouserpass.php: Added. 16 * platform/gtk/Skipped: 17 * platform/mac-leopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added. 18 * platform/mac-snowleopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added. 19 * platform/mac-tiger/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added. 20 * platform/qt/Skipped: 21 1 22 2010-12-23 Ryosuke Niwa <rniwa@webkit.org> 2 23 -
trunk/LayoutTests/platform/gtk/Skipped
r74605 r74609 5586 5586 # https://bugs.webkit.org/show_bug.cgi?id=51380 5587 5587 http/tests/inspector/console-websocket-error.html 5588 5589 # Passing just a username or just a password to 5590 # layoutTestController.queueLoad() does not work 5591 http/tests/xmlhttprequest/basic-auth-nouser.html 5592 http/tests/xmlhttprequest/basic-auth-password.html -
trunk/LayoutTests/platform/qt/Skipped
r74486 r74609 275 275 editing/inserting/5994480-2.html 276 276 editing/inserting/insert-bg-font.html 277 278 # http://bugreports.qt.nokia.com/browse/QTBUG-15566 279 http/tests/xmlhttprequest/basic-auth-nouser.html 277 280 278 281 # =========================================================================== # -
trunk/WebCore/ChangeLog
r74603 r74609 1 2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com> 2 3 Reviewed by Adam Barth. 4 5 [Qt] User name/password stripped from URLs 6 https://bugs.webkit.org/show_bug.cgi?id=36232 7 8 If a username but no password or no username but a password is present 9 in a URL, QtWebKit won't send any authentication information down to Qt 10 as it should. 11 12 Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html 13 http/tests/xmlhttprequest/basic-auth-nouser.html 14 15 * platform/network/qt/ResourceHandleQt.cpp: 16 (WebCore::ResourceHandle::start): 17 (WebCore::ResourceHandle::loadResourceSynchronously): 18 1 19 2010-12-23 Ryosuke Niwa <rniwa@webkit.org> 2 20 -
trunk/WebCore/platform/network/qt/ResourceHandleQt.cpp
r73710 r74609 125 125 return false; 126 126 127 if (! (d->m_user.isEmpty() || d->m_pass.isEmpty())) {127 if (!d->m_user.isEmpty() || !d->m_pass.isEmpty()) { 128 128 // If credentials were specified for this request, add them to the url, 129 129 // so that they will be passed to QNetworkRequest. … … 187 187 188 188 ResourceHandleInternal* d = handle->getInternal(); 189 if (! (d->m_user.isEmpty() || d->m_pass.isEmpty())) {189 if (!d->m_user.isEmpty() || !d->m_pass.isEmpty()) { 190 190 // If credentials were specified for this request, add them to the url, 191 191 // so that they will be passed to QNetworkRequest.
Note:
See TracChangeset
for help on using the changeset viewer.