Changeset 74642 in webkit

Timestamp:

Dec 24, 2010 10:55:35 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-24 Jan Erik Hanssen <​jhanssen@sencha.com>

Reviewed by Eric Seidel.

Clean up CSSRuleData in CSSStyleSelector.h
​https://bugs.webkit.org/show_bug.cgi?id=27753

Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.

• css/CSSStyleSelector.cpp: (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleData::position): (WebCore::CSSRuleData::rule): (WebCore::CSSRuleData::selector): (WebCore::CSSRuleData::next): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::~CSSRuleDataList): (WebCore::CSSRuleDataList::first): (WebCore::CSSRuleDataList::last): (WebCore::CSSRuleDataList::append):
• css/CSSStyleSelector.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSStyleSelector.cpp (modified) (1 diff)
• css/CSSStyleSelector.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>
+
+        Reviewed by Eric Seidel.
+
+        Clean up CSSRuleData in CSSStyleSelector.h
+        https://bugs.webkit.org/show_bug.cgi?id=27753
+
+        Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSRuleData::CSSRuleData):
+        (WebCore::CSSRuleData::~CSSRuleData):
+        (WebCore::CSSRuleData::position):
+        (WebCore::CSSRuleData::rule):
+        (WebCore::CSSRuleData::selector):
+        (WebCore::CSSRuleData::next):
+        (WebCore::CSSRuleDataList::CSSRuleDataList):
+        (WebCore::CSSRuleDataList::~CSSRuleDataList):
+        (WebCore::CSSRuleDataList::first):
+        (WebCore::CSSRuleDataList::last):
+        (WebCore::CSSRuleDataList::append):
+        * css/CSSStyleSelector.h:
+
 2010-12-24  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/WebCore/css/CSSStyleSelector.cpp

@@ -349 +349 @@
 }
 
+class CSSRuleData : public Noncopyable {
+public:
+    CSSRuleData(unsigned pos, CSSStyleRule* r, CSSSelector* sel, CSSRuleData* prev = 0)
+        : m_position(pos)
+        , m_rule(r)
+        , m_selector(sel)
+        , m_next(0)
+    {
+        if (prev)
+            prev->m_next = this;
+    }
+
+    ~CSSRuleData()
+    {
+    }
+
+    unsigned position() { return m_position; }
+    CSSStyleRule* rule() { return m_rule; }
+    CSSSelector* selector() { return m_selector; }
+    CSSRuleData* next() { return m_next; }
+
+private:
+    unsigned m_position;
+    CSSStyleRule* m_rule;
+    CSSSelector* m_selector;
+    CSSRuleData* m_next;
+};
+
+class CSSRuleDataList : public Noncopyable {
+public:
+    CSSRuleDataList(unsigned pos, CSSStyleRule* rule, CSSSelector* sel)
+        : m_first(new CSSRuleData(pos, rule, sel))
+        , m_last(m_first)
+    {
+    }
+
+    ~CSSRuleDataList()
+    {
+        CSSRuleData* ptr;
+        CSSRuleData* next;
+        ptr = m_first;
+        while (ptr) {
+            next = ptr->next();
+            delete ptr;
+            ptr = next;
+        }
+    }
+
+    CSSRuleData* first() { return m_first; }
+    CSSRuleData* last() { return m_last; }
+
+    void append(unsigned pos, CSSStyleRule* rule, CSSSelector* sel) { m_last = new CSSRuleData(pos, rule, sel, m_last); }
+
+private:
+    CSSRuleData* m_first;
+    CSSRuleData* m_last;
+};
+
 class CSSRuleSet : public Noncopyable {
 public:

trunk/WebCore/css/CSSStyleSelector.h

@@ -316 +316 @@
     };
 
-    class CSSRuleData : public Noncopyable {
-    public:
-        CSSRuleData(unsigned pos, CSSStyleRule* r, CSSSelector* sel, CSSRuleData* prev = 0)
-            : m_position(pos)
-            , m_rule(r)
-            , m_selector(sel)
-            , m_next(0)
-        {
-            if (prev)
-                prev->m_next = this;
-        }
-
-        ~CSSRuleData() 
-        { 
-        }
-
-        unsigned position() { return m_position; }
-        CSSStyleRule* rule() { return m_rule; }
-        CSSSelector* selector() { return m_selector; }
-        CSSRuleData* next() { return m_next; }
-
-    private:
-        unsigned m_position;
-        CSSStyleRule* m_rule;
-        CSSSelector* m_selector;
-        CSSRuleData* m_next;
-    };
-
-    class CSSRuleDataList : public Noncopyable {
-    public:
-        CSSRuleDataList(unsigned pos, CSSStyleRule* rule, CSSSelector* sel)
-            : m_first(new CSSRuleData(pos, rule, sel))
-            , m_last(m_first)
-        {
-        }
-
-        ~CSSRuleDataList() 
-        { 
-            CSSRuleData* ptr;
-            CSSRuleData* next;
-            ptr = m_first;
-            while (ptr) {
-                next = ptr->next();
-                delete ptr;
-                ptr = next;
-            }
-        }
-
-        CSSRuleData* first() { return m_first; }
-        CSSRuleData* last() { return m_last; }
-
-        void append(unsigned pos, CSSStyleRule* rule, CSSSelector* sel) { m_last = new CSSRuleData(pos, rule, sel, m_last); }
-
-    private:
-        CSSRuleData* m_first;
-        CSSRuleData* m_last;
-    };
-
 } // namespace WebCore