Changeset 74735 in webkit

Timestamp:

Dec 29, 2010 1:22:19 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2010-12-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Eric Seidel.

Remove entry for editing/input/ime-composition-clearpreedit.html test.
​https://bugs.webkit.org/show_bug.cgi?id=51693

• platform/chromium/test_expectations.txt:

2010-12-29 Zhe Su <​suzhe@chromium.org>

Reviewed by Eric Seidel.

Fix editing/input/ime-composition-clearpreedit.html test in chromium
by removing the line "editor->confirmComposition(text);" from
WebFrameImpl::setMarkedText() method, because that line will insert the
text into the focused node, which is apparently wrong.

​https://bugs.webkit.org/show_bug.cgi?id=51693

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/test_expectations.txt (modified) (1 diff)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/src/WebFrameImpl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-12-29  Zhe Su  <suzhe@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Remove entry for editing/input/ime-composition-clearpreedit.html test.
+        https://bugs.webkit.org/show_bug.cgi?id=51693
+
+        * platform/chromium/test_expectations.txt:
+
 2010-12-28  Daniel Bates  <dbates@rim.com>
 

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -3283 +3283 @@
 BUGCR67935 WIN : fast/canvas/webgl/gl-pixelstorei.html = CRASH
 
-BUGCR67960 : editing/input/ime-composition-clearpreedit.html = TEXT
-
 // WebKit roll 74667:74679
 BUGCR68067 LINUX DEBUG : fast/canvas/webgl/tex-image-with-format-and-type.html = TEXT

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-12-29  Zhe Su  <suzhe@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix editing/input/ime-composition-clearpreedit.html test in chromium
+        by removing the line "editor->confirmComposition(text);" from
+        WebFrameImpl::setMarkedText() method, because that line will insert the
+        text into the focused node, which is apparently wrong.
+
+        https://bugs.webkit.org/show_bug.cgi?id=51693
+
+        * src/WebFrameImpl.cpp:
+        (WebKit::WebFrameImpl::setMarkedText):
+
 2010-12-23  Zhenyao Mo  <zmo@google.com>
 

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -1082 +1082 @@
     Editor* editor = frame()->editor();
 
-    editor->confirmComposition(text);
-
     Vector<CompositionUnderline> decorations;
     editor->setComposition(text, decorations, location, length);