Changeset 75198 in webkit


Ignore:
Timestamp:
Jan 6, 2011 2:07:41 PM (13 years ago)
Author:
tonyg@chromium.org
Message:

2011-01-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Allow framesets after hidden inputs
​https://bugs.webkit.org/show_bug.cgi?id=51998

  • html5lib/resources/webkit01.dat: Demonstrate that the value of the type attribute matters. An input with no type is tested in tests19.dat.

2011-01-06 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Allow framesets after hidden inputs
​https://bugs.webkit.org/show_bug.cgi?id=51998

This implements the HTML5 spec update in response to:
​http://www.w3.org/Bugs/Public/show_bug.cgi?id=11156

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r75195 r75198  
     12011-01-06  Tony Gentilcore  <tonyg@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Allow framesets after hidden inputs
     6        https://bugs.webkit.org/show_bug.cgi?id=51998
     7
     8        * html5lib/resources/webkit01.dat: Demonstrate that the value of the type attribute matters. An input with no type is tested in tests19.dat.
     9
    1102010-12-29  Zhenyao Mo  <zmo@google.com>
    211

  • trunk/LayoutTests/html5lib/resources/webkit01.dat

    r71209 r75198  
    588588|         <math mi>
    589589|           "a"
     590
     591#data
     592<!doctype html><input type="hidden"><frameset>
     593#errors
     594#document
     595| <!DOCTYPE html>
     596| <html>
     597|   <head>
     598|   <frameset>
     599
     600#data
     601<!doctype html><input type="button"><frameset>
     602#errors
     603#document
     604| <!DOCTYPE html>
     605| <html>
     606|   <head>
     607|   <body>
     608|     <input>
     609|       type="button"

  • trunk/WebCore/ChangeLog

    r75195 r75198  
     12011-01-06  Tony Gentilcore  <tonyg@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Allow framesets after hidden inputs
     6        https://bugs.webkit.org/show_bug.cgi?id=51998
     7
     8        This implements the HTML5 spec update in response to:
     9        http://www.w3.org/Bugs/Public/show_bug.cgi?id=11156
     10
     11        * html/parser/HTMLTreeBuilder.cpp:
     12        (WebCore::HTMLTreeBuilder::processStartTagForInBody):
     13
    1142010-12-29  Zhenyao Mo  <zmo@google.com>
    215

  • trunk/WebCore/html/parser/HTMLTreeBuilder.cpp

    r74663 r75198  
    894894        || token.name() == embedTag
    895895        || token.name() == imgTag
    896         || token.name() == inputTag
    897896        || token.name() == keygenTag
    898897        || token.name() == wbrTag) {
    … …  
    900899        m_tree.insertSelfClosingHTMLElement(token);
    901900        m_framesetOk = false;
     901        return;
     902    }
     903    if (token.name() == inputTag) {
     904        RefPtr<Attribute> typeAttribute = token.getAttributeItem(typeAttr);
     905        m_tree.reconstructTheActiveFormattingElements();
     906        m_tree.insertSelfClosingHTMLElement(token);
     907        if (!typeAttribute || !equalIgnoringCase(typeAttribute->value(), "hidden"))
     908            m_framesetOk = false;
    902909        return;
    903910    }
Note: See TracChangeset for help on using the changeset viewer.