Changeset 76029 in webkit


Ignore:
Timestamp:
Jan 18, 2011 9:19:15 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

  • platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
  • svg/css/text-gradient-shadow.svg: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

Test: svg/css/text-gradient-shadow.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r76028 r76029  
     12011-01-18  Helder Correia  <helder@sencha.com>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        REGRESSION(75139): SVG gradients are not applied to texts
     6        https://bugs.webkit.org/show_bug.cgi?id=52531
     7
     8        r75139 caused a problem with filling and stroking text with a gradient
     9        fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
     10        was mixed up.
     11
     12        * platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
     13        * platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
     14        * platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
     15        * svg/css/text-gradient-shadow.svg: Added.
     16
    1172011-01-18  John Knottenbelt  <jknotten@chromium.org>
    218
  • trunk/Source/WebCore/ChangeLog

    r76027 r76029  
     12011-01-18  Helder Correia  <helder@sencha.com>
     2
     3        Reviewed by Dirk Schulze.
     4
     5        REGRESSION(75139): SVG gradients are not applied to texts
     6        https://bugs.webkit.org/show_bug.cgi?id=52531
     7
     8        r75139 caused a problem with filling and stroking text with a gradient
     9        fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
     10        was mixed up.
     11
     12        Test: svg/css/text-gradient-shadow.svg
     13
     14        * platform/graphics/cg/GraphicsContextCG.cpp:
     15        (WebCore::GraphicsContext::fillRect):
     16
    1172011-01-18  Leo Yang  <leo.yang@torchmobile.com.cn>
    218
  • trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

    r75833 r76029  
    626626    if (m_state.fillGradient) {
    627627        CGContextSaveGState(context);
    628         CGContextConcatCTM(context, m_state.fillGradient->gradientSpaceTransform());
    629628        if (hasShadow()) {
     629            CGContextConcatCTM(context, m_state.fillGradient->gradientSpaceTransform());
    630630            CGLayerRef layer = CGLayerCreateWithContext(context, CGSizeMake(rect.width(), rect.height()), 0);
    631631            CGContextRef layerContext = CGLayerGetContext(layer);
     
    635635        } else {
    636636            CGContextClipToRect(context, rect);
     637            CGContextConcatCTM(context, m_state.fillGradient->gradientSpaceTransform());
    637638            m_state.fillGradient->paint(this);
    638639        }
Note: See TracChangeset for help on using the changeset viewer.