Changeset 76179 in webkit

Timestamp:

Jan 19, 2011 4:27:47 PM (13 years ago)

Author:

andersca@apple.com

Message:

2011-01-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

When resizing, the web process should repaint the page
​https://bugs.webkit.org/show_bug.cgi?id=52764

• UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Incorporate the update.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Return early if the update bounds rect is empty. This can happen if painting is
disabled and we get a DidSetSize message.

• WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): If painting is disabled, just send back an empty UpdateInfo struct. Otherwise, paint and fill in the UpdateInfo struct.

(WebKit::DrawingAreaImpl::display):
Assert that painting is not disabled.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/DrawingAreaProxyImpl.cpp (modified) (1 diff)
• WebProcess/WebPage/DrawingAreaImpl.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-01-19  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        When resizing, the web process should repaint the page
+        https://bugs.webkit.org/show_bug.cgi?id=52764
+
+        * UIProcess/DrawingAreaProxyImpl.cpp:
+        (WebKit::DrawingAreaProxyImpl::didSetSize):
+        Incorporate the update.
+
+        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
+        Return early if the update bounds rect is empty. This can happen if painting is
+        disabled and we get a DidSetSize message.
+
+        * WebProcess/WebPage/DrawingAreaImpl.cpp:
+        (WebKit::DrawingAreaImpl::setSize):
+        If painting is disabled, just send back an empty UpdateInfo struct. Otherwise,
+        paint and fill in the UpdateInfo struct.
+
+        (WebKit::DrawingAreaImpl::display):
+        Assert that painting is not disabled.
+
 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp

@@ -126 +126 @@
 
     m_backingStore = nullptr;
+
+    incorporateUpdate(updateInfo);
 }
 
 void DrawingAreaProxyImpl::incorporateUpdate(const UpdateInfo& updateInfo)
 {
-    // FIXME: Check for the update bounds being empty here.
+    if (updateInfo.updateRectBounds.isEmpty())
+        return;
 
     if (!m_backingStore)

trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp

@@ -143 +143 @@
 
     UpdateInfo updateInfo;
-    updateInfo.viewSize = m_webPage->size();
-
-    // FIXME: Repaint.
+
+    if (m_isPaintingSuspended)
+        updateInfo.viewSize = m_webPage->size();
+    else
+        display(updateInfo);
 
     m_webPage->send(Messages::DrawingAreaProxy::DidSetSize(updateInfo));
@@ -232 +234 @@
 void DrawingAreaImpl::display(UpdateInfo& updateInfo)
 {
+    ASSERT(!m_isPaintingSuspended);
+
     // FIXME: It would be better if we could avoid painting altogether when there is a custom representation.
     if (m_webPage->mainFrameHasCustomRepresentation())