Changeset 76592 in webkit


Ignore:
Timestamp:
Jan 25, 2011 7:24:45 AM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-01-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
https://bugs.webkit.org/show_bug.cgi?id=51873

Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
No new functionality so no new tests.

  • html/canvas/Int32Array.h: (WebCore::Int32Array::set):
  • html/canvas/Int8Array.h: (WebCore::Int8Array::set):
  • html/canvas/Uint16Array.h: (WebCore::Uint16Array::set):
  • html/canvas/Uint32Array.h: (WebCore::Uint32Array::set):
  • html/canvas/Uint8Array.h: (WebCore::Uint8Array::set):
Location:
trunk/Source/WebCore
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r76590 r76592  
     12011-01-25  Qi Zhang  <qi.2.zhang@nokia.com>
     2
     3        Reviewed by Laszlo Gombos.
     4
     5        [Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
     6        https://bugs.webkit.org/show_bug.cgi?id=51873
     7       
     8        Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
     9        No new functionality so no new tests.
     10
     11        * html/canvas/Int32Array.h:
     12        (WebCore::Int32Array::set):
     13        * html/canvas/Int8Array.h:
     14        (WebCore::Int8Array::set):
     15        * html/canvas/Uint16Array.h:
     16        (WebCore::Uint16Array::set):
     17        * html/canvas/Uint32Array.h:
     18        (WebCore::Uint32Array::set):
     19        * html/canvas/Uint8Array.h:
     20        (WebCore::Uint8Array::set):
     21
    1222011-01-25  Zoltan Herczeg  <zherczeg@webkit.org>
    223
  • trunk/Source/WebCore/html/canvas/Int32Array.h

    r72343 r76592  
    3838    static PassRefPtr<Int32Array> create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length);
    3939
    40 #if !COMPILER(RVCT)
    41     using TypedArrayBase<int>::set;
    42     using IntegralTypedArrayBase<int>::set;
    43 #endif
     40    // Can’t use "using" here due to a bug in the RVCT compiler.
     41    void set(TypedArrayBase<int>* array, unsigned offset, ExceptionCode& ec) { return TypedArrayBase<int>::set(array, offset, ec); }
     42    void set(unsigned index, double value) { return IntegralTypedArrayBase<int>::set(index, value); }
    4443
    4544    PassRefPtr<Int32Array> slice(int start) const;
  • trunk/Source/WebCore/html/canvas/Int8Array.h

    r72343 r76592  
    4040    static PassRefPtr<Int8Array> create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length);
    4141
    42     using TypedArrayBase<signed char>::set;
    43     using IntegralTypedArrayBase<signed char>::set;
     42    // Can’t use "using" here due to a bug in the RVCT compiler.
     43    void set(TypedArrayBase<signed char>* array, unsigned offset, ExceptionCode& ec) { return TypedArrayBase<signed char>::set(array, offset, ec); }
     44    void set(unsigned index, double value) { return IntegralTypedArrayBase<signed char>::set(index, value); }
    4445
    4546    PassRefPtr<Int8Array> slice(int start) const;
  • trunk/Source/WebCore/html/canvas/Uint16Array.h

    r72343 r76592  
    4040    static PassRefPtr<Uint16Array> create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length);
    4141
    42     using TypedArrayBase<unsigned short>::set;
    43     using IntegralTypedArrayBase<unsigned short>::set;
     42    // Can’t use "using" here due to a bug in the RVCT compiler.
     43    void set(TypedArrayBase<unsigned short>* array, unsigned offset, ExceptionCode& ec) { return TypedArrayBase<unsigned short>::set(array, offset, ec); }
     44    void set(unsigned index, double value) { return IntegralTypedArrayBase<unsigned short>::set(index, value); }
    4445
    4546    PassRefPtr<Uint16Array> slice(int start) const;
  • trunk/Source/WebCore/html/canvas/Uint32Array.h

    r72343 r76592  
    4040    static PassRefPtr<Uint32Array> create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length);
    4141
    42     using TypedArrayBase<unsigned int>::set;
    43     using IntegralTypedArrayBase<unsigned int>::set;
     42    // Can’t use "using" here due to a bug in the RVCT compiler.
     43    void set(TypedArrayBase<unsigned int>* array, unsigned offset, ExceptionCode& ec) { return TypedArrayBase<unsigned int>::set(array, offset, ec); }
     44    void set(unsigned index, double value) { return IntegralTypedArrayBase<unsigned int>::set(index, value); }
    4445
    4546    PassRefPtr<Uint32Array> slice(int start) const;
  • trunk/Source/WebCore/html/canvas/Uint8Array.h

    r72343 r76592  
    4040    static PassRefPtr<Uint8Array> create(PassRefPtr<ArrayBuffer> buffer, unsigned byteOffset, unsigned length);
    4141
    42 #if !COMPILER(RVCT)
    43     using TypedArrayBase<unsigned char>::set;
    44     using IntegralTypedArrayBase<unsigned char>::set;
    45 #endif
     42    // Can’t use "using" here due to a bug in the RVCT compiler.
     43    void set(TypedArrayBase<unsigned char>* array, unsigned offset, ExceptionCode& ec) { return TypedArrayBase<unsigned char>::set(array, offset, ec); }
     44    void set(unsigned index, double value) { return IntegralTypedArrayBase<unsigned char>::set(index, value); }
    4645
    4746    PassRefPtr<Uint8Array> slice(int start) const;
Note: See TracChangeset for help on using the changeset viewer.