Changeset 76609 in webkit

Timestamp:

Jan 25, 2011 10:28:35 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-01-25 Marcilio Mendonca <​mamendonca@rim.com>

Reviewed by Darin Adler.

Bug 53087: Refactoring: replaced a hanging "else" with a "return"
statement
​https://bugs.webkit.org/show_bug.cgi?id=53087.

Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
with a "return" so that the code is more readable and less error pro
(e.g., "else" doesn't use braces so adding extra lines to the else
block won't have any effect; even worse, code still compiles
successfully.

• wtf/Assertions.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• wtf/Assertions.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-01-25  Marcilio Mendonca  <mamendonca@rim.com>
+
+        Reviewed by Darin Adler.
+
+        Bug 53087: Refactoring: replaced a hanging "else" with a "return"
+        statement
+        https://bugs.webkit.org/show_bug.cgi?id=53087.
+
+        Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
+        with a "return" so that the code is more readable and less error pro
+        (e.g., "else" doesn't use braces so adding extra lines to the else
+        block won't have any effect; even worse, code still compiles
+        successfully.
+
+        * wtf/Assertions.cpp:
+
 2011-01-24  Chris Marrin  <cmarrin@apple.com>
 

trunk/Source/JavaScriptCore/wtf/Assertions.cpp

@@ -102 +102 @@
         CFRelease(str);
         CFRelease(cfFormat);
-    } else
+        return;
+    }
 #elif PLATFORM(BREWMP)
     // When str is 0, the return value is the number of bytes needed