Changeset 76610 in webkit
- Timestamp:
- Jan 25, 2011 10:42:43 AM (13 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r76607 r76610 1 2011-01-25 Benjamin Kalman <kalman@chromium.org> 2 3 Reviewed by Ryosuke Niwa. 4 5 Cannot extend or modify forward by word over a non-contenteditable region 6 https://bugs.webkit.org/show_bug.cgi?id=53070 7 8 Add regression test. 9 10 * editing/selection/extend-forward-by-word-over-non-editable-expected.txt: Added. 11 * editing/selection/extend-forward-by-word-over-non-editable.html: Added. 12 1 13 2011-01-25 Ryosuke Niwa <rniwa@webkit.org> 2 14 -
trunk/Source/WebCore/ChangeLog
r76606 r76610 1 2011-01-25 Benjamin Kalman <kalman@chromium.org> 2 3 Reviewed by Ryosuke Niwa. 4 5 Cannot extend or modify forward by word over a non-contenteditable region 6 https://bugs.webkit.org/show_bug.cgi?id=53070 7 8 Test: editing/selection/extend-forward-by-word-over-non-editable.html 9 10 Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the 11 functions which determine the end/start of words/lines/sentences in visible_units.cpp. 12 13 This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor 14 inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore. 15 The cursor is now moved to the end of the region (which is effectively a noop in this case). 16 17 * editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to 18 honorEditableBoundaryAtOrBefore and vice versa. 19 (WebCore::previousWordPosition): 20 (WebCore::nextWordPosition): 21 (WebCore::startOfLine): 22 (WebCore::endOfLine): 23 (WebCore::previousSentencePosition): 24 (WebCore::nextSentencePosition): 25 (WebCore::logicalStartOfLine): 26 (WebCore::logicalEndOfLine): 27 1 28 2011-01-25 Yael Aharon <yael.aharon@nokia.com> 2 29 -
trunk/Source/WebCore/editing/visible_units.cpp
r76438 r76610 293 293 { 294 294 VisiblePosition prev = previousBoundary(c, previousWordPositionBoundary); 295 return c.honorEditableBoundaryAtOr After(prev);295 return c.honorEditableBoundaryAtOrBefore(prev); 296 296 } 297 297 … … 309 309 { 310 310 VisiblePosition next = nextBoundary(c, nextWordPositionBoundary); 311 return c.honorEditableBoundaryAtOr Before(next);311 return c.honorEditableBoundaryAtOrAfter(next); 312 312 } 313 313 … … 392 392 VisiblePosition visPos = startPositionForLine(c); 393 393 394 return c.honorEditableBoundaryAtOr After(visPos);394 return c.honorEditableBoundaryAtOrBefore(visPos); 395 395 } 396 396 … … 459 459 } 460 460 461 return c.honorEditableBoundaryAtOr Before(visPos);461 return c.honorEditableBoundaryAtOrAfter(visPos); 462 462 } 463 463 … … 721 721 { 722 722 VisiblePosition prev = previousBoundary(c, previousSentencePositionBoundary); 723 return c.honorEditableBoundaryAtOr After(prev);723 return c.honorEditableBoundaryAtOrBefore(prev); 724 724 } 725 725 … … 735 735 { 736 736 VisiblePosition next = nextBoundary(c, nextSentencePositionBoundary); 737 return c.honorEditableBoundaryAtOr Before(next);737 return c.honorEditableBoundaryAtOrAfter(next); 738 738 } 739 739 … … 1134 1134 VisiblePosition visPos = logicalStartPositionForLine(c); 1135 1135 1136 return c.honorEditableBoundaryAtOr After(visPos);1136 return c.honorEditableBoundaryAtOrBefore(visPos); 1137 1137 } 1138 1138 … … 1191 1191 visPos = visPos.previous(); 1192 1192 1193 return c.honorEditableBoundaryAtOr Before(visPos);1193 return c.honorEditableBoundaryAtOrAfter(visPos); 1194 1194 } 1195 1195
Note: See TracChangeset
for help on using the changeset viewer.