Changeset 76635 in webkit

Timestamp:

Jan 25, 2011, 1:13:55 PM (15 years ago)

Author:

oliver@apple.com

Message:

2011-01-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

JSON.stringify processing time exponentially grows with size of object
​https://bugs.webkit.org/show_bug.cgi?id=51922

Remove last use of reserveCapacity from JSON stringification, as it results
in appalling append behaviour when there are a large number of property names
and nothing else.

• runtime/JSONObject.cpp: (JSC::Stringifier::appendQuotedString):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSONObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-01-25  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        JSON.stringify processing time exponentially grows with size of object
+        https://bugs.webkit.org/show_bug.cgi?id=51922
+
+        Remove last use of reserveCapacity from JSON stringification, as it results
+        in appalling append behaviour when there are a large number of property names
+        and nothing else.
+
+        * runtime/JSONObject.cpp:
+        (JSC::Stringifier::appendQuotedString):
+
 2011-01-25  Antti Koivisto  <antti@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

@@ -284 +284 @@
 {
     int length = value.length();
-
-    // String length plus 2 for quote marks plus 8 so we can accomodate a few escaped characters.
-    builder.reserveCapacity(builder.length() + length + 2 + 8);
 
     builder.append('"');