Changeset 76658 in webkit

Timestamp:

Jan 25, 2011 6:13:46 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-01-25 Mike Reed <​reed@google.com>

Reviewed by James Robinson.

DrawingBufer::reset() today checks if the new size is the same as its
m_size, and if so, returns immediately. This does not match the
semantics of <canvas>, which wants to clear its contents anytime the
size is specified.
​https://bugs.webkit.org/show_bug.cgi?id=53149

Test: Covered by existing <canvas> tests using gpu.

• platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
• platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/chromium/DrawingBufferChromium.cpp (modified) (1 diff)
• platform/graphics/gpu/DrawingBuffer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-25  Mike Reed  <reed@google.com>
+
+        Reviewed by James Robinson.
+
+        DrawingBufer::reset() today checks if the new size is the same as its
+        m_size, and if so, returns immediately. This does not match the
+        semantics of <canvas>, which wants to clear its contents anytime the
+        size is specified.
+        https://bugs.webkit.org/show_bug.cgi?id=53149
+
+        Test: Covered by existing <canvas> tests using gpu.
+
+        * platform/graphics/chromium/DrawingBufferChromium.cpp:
+        (WebCore::DrawingBuffer::DrawingBuffer):
+        * platform/graphics/gpu/DrawingBuffer.cpp:
+        (WebCore::DrawingBuffer::reset):
+
 2011-01-25  Cris Neckar  <cdn@chromium.org>
 

trunk/Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp

@@ -73 +73 @@
                              bool packedDepthStencilExtensionSupported)
     : m_context(context)
-    , m_size(-1, -1)
+    , m_size(size)
     , m_multisampleExtensionSupported(multisampleExtensionSupported)
     , m_packedDepthStencilExtensionSupported(packedDepthStencilExtensionSupported)

trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp

@@ -146 +146 @@
 void DrawingBuffer::reset(const IntSize& newSize)
 {
-    if (m_size == newSize)
-        return;
     m_size = newSize;