Changeset 76689 in webkit

Timestamp:

Jan 26, 2011 7:51:35 AM (13 years ago)

Author:

carol.szabo@nokia.com

Message:

2011-01-26 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Simon Hausmann.

Fixed TiledBacking store to take into account new dirty regions caused by
paint time layouts.

Flawed rendering design for QtWebKit resulting in artifacts being displayed
​https://bugs.webkit.org/show_bug.cgi?id=49184

There are no new tests as this patch aims at fixing flicker that
happen randomly, mostly on slow hardware, thus are hard to reproduce
consistently in an automated test.

This patch does not fully address the said bug but it is a step in the
right direction. A full solution to the bug, as currently perceived,
requires either a Qt GUI API change, a performance hit for QtWebKit,
or a hack, until a full solution is provided this patch is progress.

• platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::updateTileBuffers): Changed to take into account newly dirtied areas created during tile update initiated layouts during the same update.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/TiledBackingStore.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-26  Carol Szabo  <carol.szabo@nokia.com>
+
+        Reviewed by Simon Hausmann.
+
+        Fixed TiledBacking store to take into account new dirty regions caused by
+        paint time layouts.
+
+        Flawed rendering design for QtWebKit resulting in artifacts being displayed
+        https://bugs.webkit.org/show_bug.cgi?id=49184
+
+        There are no new tests as this patch aims at fixing flicker that
+        happen randomly, mostly on slow hardware, thus are hard to reproduce
+        consistently in an automated test.
+
+        This patch does not fully address the said bug but it is a step in the
+        right direction. A full solution to the bug, as currently perceived,
+        requires either a Qt GUI API change, a performance hit for QtWebKit,
+        or a hack, until a full solution is provided this patch is progress.
+
+        * platform/graphics/TiledBackingStore.cpp:
+        (WebCore::TiledBackingStore::updateTileBuffers):
+        Changed to take into account newly dirtied areas created during
+        tile update initiated layouts during the same update.
+
 2011-01-26  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

@@ -94 +94 @@
         return;
     
+    m_client->tiledBackingStorePaintBegin();
+
     Vector<IntRect> paintedArea;
     Vector<RefPtr<Tile> > dirtyTiles;
@@ -105 +107 @@
     }
     
-    if (dirtyTiles.isEmpty())
-        return;
-    
-    m_client->tiledBackingStorePaintBegin();
-
+    if (dirtyTiles.isEmpty()) {
+        m_client->tiledBackingStorePaintEnd(paintedArea);
+        return;
+    }
     // FIXME: In single threaded case, tile back buffers could be updated asynchronously 
     // one by one and then swapped to front in one go. This would minimize the time spent