Changeset 76911 in webkit


Ignore:
Timestamp:
Jan 27, 2011 7:30:24 PM (13 years ago)
Author:
rniwa@webkit.org
Message:

2011-01-27 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed, rolling out r76839.
​http://trac.webkit.org/changeset/76839
​https://bugs.webkit.org/show_bug.cgi?id=49744

broke pixel tests

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-27 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed, rolling out r76839.
​http://trac.webkit.org/changeset/76839
​https://bugs.webkit.org/show_bug.cgi?id=49744

broke pixel tests

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
  • editing/selection/caret-painting-after-paste-undo.html: Removed.
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
Location:
trunk
Files:
8 deleted
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r76908 r76911  
     12011-01-27  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Unreviewed, rolling out r76839.
     4        http://trac.webkit.org/changeset/76839
     5        https://bugs.webkit.org/show_bug.cgi?id=49744
     6
     7        broke pixel tests
     8
     9        * editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
     10        * editing/selection/caret-painting-after-paste-undo.html: Removed.
     11        * platform/mac/editing/deleting/5408255-expected.png:
     12        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
     13        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
     14        * platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
     15        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
     16        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
     17        * platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
     18
    1192011-01-27  Maciej Stachowiak  <mjs@apple.com>
    220

  • trunk/Source/WebCore/ChangeLog

    r76903 r76911  
     12011-01-27  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Unreviewed, rolling out r76839.
     4        http://trac.webkit.org/changeset/76839
     5        https://bugs.webkit.org/show_bug.cgi?id=49744
     6
     7        broke pixel tests
     8
     9        * rendering/RenderBox.cpp:
     10        (WebCore::RenderBox::localCaretRect):
     11
    1122011-01-27  Emil A Eklund  <eae@chromium.org>
    213

  • trunk/Source/WebCore/rendering/RenderBox.cpp

    r76839 r76911  
    29612961    // FIXME: Paint the carets inside empty blocks differently than the carets before/after elements.
    29622962
     2963    // FIXME: What about border and padding?
    29632964    IntRect rect(x(), y(), caretWidth, height());
    29642965    bool ltr = box ? box->isLeftToRightDirection() : style()->isLeftToRightDirection();
    29652966
    2966     if (isTable()) {
    2967         if ((!caretOffset) ^ ltr)
    2968             rect.move(IntSize(width() - caretWidth, 0));
    2969     } else if ((!caretOffset) ^ ltr)
    2970         rect.move(IntSize(width() - caretWidth - borderRight() - paddingRight(), borderTop() + paddingTop()));
    2971     else
    2972         rect.move(IntSize(borderLeft() + paddingLeft(), borderTop() + paddingTop()));
     2967    if ((!caretOffset) ^ ltr)
     2968        rect.move(IntSize(width() - caretWidth, 0));
    29732969
    29742970    if (box) {
Note: See TracChangeset for help on using the changeset viewer.