Changeset 77067 in webkit

Timestamp:

Jan 29, 2011 12:31:29 PM (13 years ago)

Author:

cwzwarich@webkit.org

Message:

Bug 53374 - Remove uses of unsafe string functions in debugging code
​https://bugs.webkit.org/show_bug.cgi?id=53374

Reviewed by David Kilzer.

• runtime/RegExp.cpp:

(JSC::RegExp::printTraceData):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/RegExp.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-01-29  Cameron Zwarich  <zwarich@apple.com>
+
+        Reviewed by David Kilzer.
+
+        Bug 53374 - Remove uses of unsafe string functions in debugging code
+        https://bugs.webkit.org/show_bug.cgi?id=53374
+
+        * runtime/RegExp.cpp:
+        (JSC::RegExp::printTraceData):
+
 2011-01-29  Cameron Zwarich  <zwarich@apple.com>
 

trunk/Source/JavaScriptCore/runtime/RegExp.cpp

@@ -231 +231 @@
         Yarr::YarrCodeBlock& codeBlock = m_representation->m_regExpJITCode;
 
-        char jitAddr[20];
+        const size_t jitAddrSize = 20;
+        char jitAddr[jitAddrSize];
         if (m_state == JITCode)
-            sprintf(jitAddr, "fallback");
+            snprintf(jitAddr, jitAddrSize, "fallback");
         else
-            sprintf(jitAddr, "0x%014lx", reinterpret_cast<unsigned long int>(codeBlock.getAddr()));
+            snprintf(jitAddr, jitAddrSize, "0x%014lx", reinterpret_cast<unsigned long int>(codeBlock.getAddr()));
 #else
         const char* jitAddr = "JIT Off";