Changeset 77127 in webkit

Timestamp:

Jan 31, 2011 6:43:18 AM (13 years ago)

Author:

pfeldman@chromium.org

Message:

2011-01-30 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
​https://bugs.webkit.org/show_bug.cgi?id=53397

• inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
• inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
• inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/DataGrid.js (modified) (1 diff)
• inspector/front-end/NetworkPanel.js (modified) (4 diffs)
• inspector/front-end/networkPanel.css (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-30  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        Web Inspector: speed up network panel rendering.
+        https://bugs.webkit.org/show_bug.cgi?id=53397
+
+        * inspector/front-end/DataGrid.js:
+        (WebInspector.DataGrid.prototype.get scrollContainer):
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor):
+        (WebInspector.NetworkPanel.prototype._positionSummaryBar):
+        (WebInspector.NetworkPanel.prototype._createTable):
+        (WebInspector.NetworkPanel.prototype._exportResource):
+        (WebInspector.NetworkPanel.prototype._onScroll):
+        * inspector/front-end/networkPanel.css:
+        (.network-sidebar .data-grid.small tr.offscreen):
+        (.network-sidebar .data-grid tr.offscreen):
+        (.network-sidebar .data-grid tr.offscreen td):
+
 2011-01-31  Peter Varga  <pvarga@webkit.org>
 

trunk/Source/WebCore/inspector/front-end/DataGrid.js

@@ -492 +492 @@
 
         this._columnWidthsInitialized = false;
+    },
+
+    get scrollContainer()
+    {
+        return this._scrollContainer;        
     },
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -104 +104 @@
     elementsToRestoreScrollPositionsFor: function()
     {
-        return [this.containerElement];
+        return [this.containerElement, this._dataGrid.scrollContainer];
     },
 
@@ -159 +159 @@
             this._sortItems();
         }
+        this._updateOffscreenRows();
     },
 
@@ -215 +216 @@
         this._dataGrid.addEventListener("sorting changed", this._sortItems, this);
         this._dataGrid.addEventListener("width changed", this._updateDividersIfNeeded, this);
+        this._dataGrid.scrollContainer.addEventListener("scroll", this._updateOffscreenRows.bind(this));
 
         this._patchTimelineHeader();
@@ -1026 +1028 @@
         var har = (new WebInspector.HAREntry(resource)).build();
         offerFileForDownload(JSON.stringify(har));
+    },
+
+    _updateOffscreenRows: function(e)
+    {
+        var dataTableBody = this._dataGrid.dataTableBody;
+        var rows = dataTableBody.children;
+        var recordsCount = rows.length;
+        if (recordsCount < 2)
+            return;  // Filler row only.
+
+        var visibleTop = this._dataGrid.scrollContainer.scrollTop;
+        var visibleBottom = visibleTop + this._dataGrid.scrollContainer.offsetHeight;
+
+        var rowHeight = rows[0].offsetHeight;
+
+        // Filler is at recordsCount - 1.
+        for (var i = 0; i < recordsCount - 1; ++i) {
+            var row = rows[i];
+            // Don't touch summaty - quit instead.
+            if (row === this._summaryBarRowNode)
+                break;
+            var rowIsVisible = i * rowHeight < visibleBottom && (i + 1) * rowHeight > visibleTop;
+            if (rowIsVisible !== row.rowIsVisible) {
+                if (rowIsVisible)
+                    row.removeStyleClass("offscreen");
+                else
+                    row.addStyleClass("offscreen");
+                row.rowIsVisible = rowIsVisible;
+            }
+        }
     }
 }

trunk/Source/WebCore/inspector/front-end/networkPanel.css

@@ -64 +64 @@
     font-size: 11px;
     font-weight: bold;
+}
+
+.network-sidebar .data-grid.small tr.offscreen {
+    height: 21px;
+}
+
+.network-sidebar .data-grid tr.offscreen {
+    height: 41px;
+}
+
+.network-sidebar .data-grid tr.offscreen td {
+    display: none;
 }