Changeset 77343 in webkit

Timestamp:

Feb 1, 2011 5:31:28 PM (13 years ago)

Author:

Martin Robinson

Message:

2011-01-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
​https://bugs.webkit.org/show_bug.cgi?id=53057

• platform/gtk/Skipped: Unskip tests which are no longer crashing.

2011-01-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
​https://bugs.webkit.org/show_bug.cgi?id=53057

Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.

• platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-01-25  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] Two tests crash after r76555
+        https://bugs.webkit.org/show_bug.cgi?id=53057
+
+        * platform/gtk/Skipped: Unskip tests which are no longer crashing.
+
 2011-02-01  chris reiss  <christopher.reiss@nokia.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -5087 +5087 @@
 media/unsupported-rtsp.html
 
-# These two crash after r76555.
-# https://bugs.webkit.org/show_bug.cgi?id=53057
-http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html
-http/tests/xmlhttprequest/simple-cross-origin-denied-events.html
-http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html
-
 # This media test fails; possibly because the AAC codec is not installed on the test bots:
 # https://bugs.webkit.org/show_bug.cgi?id=53125

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-01-25  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] Two tests crash after r76555
+        https://bugs.webkit.org/show_bug.cgi?id=53057
+
+        Instead of creating synchronous ResourceHandles manually, use the ::create factory.
+        This ensures that ::start() is not called when there is a scheduled failure and also
+        reduces code duplication.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
+
 2011-02-01  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

@@ -790 +790 @@
 {
     WebCoreSynchronousLoader syncLoader(error, response, data);
-    // FIXME: we should use the ResourceHandle::create method here,
-    // but it makes us timeout in a couple of tests. See
-    // https://bugs.webkit.org/show_bug.cgi?id=41823
-    RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(request, &syncLoader, false /*defersLoading*/, false /*shouldContentSniff*/));
-    handle->start(context);
+    RefPtr<ResourceHandle> handle = create(context, request, &syncLoader, false /*defersLoading*/, false /*shouldContentSniff*/);
+    if (!handle)
+        return;
 
     // If the request has already failed, do not run the main loop, or else we'll block indefinitely.