Changeset 77398 in webkit

Timestamp:

Feb 2, 2011 12:20:36 PM (13 years ago)

Author:

hyatt@apple.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Darin Adler.

Remove physical accessors from IntRect and FloatRect.

• page/FrameView.cpp:

(WebCore::FrameView::adjustPageHeightDeprecated):

• platform/graphics/FloatRect.h:
• platform/graphics/IntRect.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)
• platform/graphics/FloatRect.h (modified) (2 diffs)
• platform/graphics/IntRect.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-02  David Hyatt  <hyatt@apple.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=53520
+
+        Remove physical accessors from IntRect and FloatRect.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::adjustPageHeightDeprecated):
+        * platform/graphics/FloatRect.h:
+        * platform/graphics/IntRect.h:
+
 2011-02-02  David Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/page/FrameView.cpp

@@ -2339 +2339 @@
         GraphicsContext context((PlatformGraphicsContext*)0);
         root->setTruncatedAt((int)floorf(oldBottom));
-        IntRect dirtyRect(0, (int)floorf(oldTop), root->rightLayoutOverflow(), (int)ceilf(oldBottom - oldTop));
+        IntRect dirtyRect(0, (int)floorf(oldTop), root->maxXLayoutOverflow(), (int)ceilf(oldBottom - oldTop));
         root->setPrintRect(dirtyRect);
         root->layer()->paint(&context, dirtyRect);

trunk/Source/WebCore/platform/graphics/FloatRect.h

@@ -103 +103 @@
     bool isEmpty() const { return m_size.isEmpty(); }
 
-    float left() const { return x(); }
-    float right() const { return x() + width(); }
-    float top() const { return y(); }
-    float bottom() const { return y() + height(); }
-
     FloatPoint center() const { return FloatPoint(x() + width() / 2, y() + height() / 2); }
 
@@ -124 +119 @@
         { return px >= x() && px <= maxX() && py >= y() && py <= maxY(); }
     bool contains(const FloatPoint& point) const { return contains(point.x(), point.y()); }
-
 
     void inflateX(float dx) {

trunk/Source/WebCore/platform/graphics/IntRect.h

@@ -104 +104 @@
     bool isEmpty() const { return m_size.isEmpty(); }
 
-    int right() const { return x() + width(); }
-    int bottom() const { return y() + height(); }
-
     // NOTE: The result is rounded to integer values, and thus may be not the exact
     // center point.