Changeset 77716 in webkit

Timestamp:

Feb 4, 2011 6:19:43 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-04 Xiyuan Xia <​xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Option text in select popup does not align with menulist button text
​https://bugs.webkit.org/show_bug.cgi?id=53632

This makes clientPaddingLeft and clientPaddingRight return
the additional m_innerBlock's padding so that the popup item text
aligns with the menulist button text.

• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::clientPaddingLeft): (WebCore::RenderMenuList::clientPaddingRight):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderMenuList.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-04  Xiyuan Xia  <xiyuan@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        [Chromium] Option text in select popup does not align with menulist button text
+        https://bugs.webkit.org/show_bug.cgi?id=53632
+
+        This makes clientPaddingLeft and  clientPaddingRight return
+        the additional m_innerBlock's padding so that the popup item text
+        aligns with the menulist button text.
+
+        * rendering/RenderMenuList.cpp:
+        (WebCore::RenderMenuList::clientPaddingLeft):
+        (WebCore::RenderMenuList::clientPaddingRight):
+
 2011-02-04  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/rendering/RenderMenuList.cpp

@@ -487 +487 @@
 int RenderMenuList::clientPaddingLeft() const
 {
-    return paddingLeft();
+    return paddingLeft() + m_innerBlock->paddingLeft();
 }
 
@@ -503 +503 @@
     // If the appearance isn't MenulistPart, then the select is styled (non-native), so
     // we want to return the user specified padding.
-    return paddingRight();
+    return paddingRight() + m_innerBlock->paddingRight();
 }