Changeset 77913 in webkit


Ignore:
Timestamp:
Feb 7, 2011 11:30:29 PM (13 years ago)
Author:
tony@chromium.org
Message:

2011-02-07 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

clean up python imports
https://bugs.webkit.org/show_bug.cgi?id=53966

Convert "import A.B.C.D as D" to "from A.B.C import D" and
make some imports absolute as required by PEP-8

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/common/system/logutils.py:
  • Scripts/webkitpy/common/system/logutils_unittest.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/prettydiff.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/roll.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
Location:
trunk/Tools
Files:
19 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r77912 r77913  
     12011-02-07  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        clean up python imports
     6        https://bugs.webkit.org/show_bug.cgi?id=53966
     7
     8        Convert "import A.B.C.D as D" to "from A.B.C import D" and
     9        make some imports absolute as required by PEP-8
     10
     11        * Scripts/webkitpy/common/checkout/scm.py:
     12        * Scripts/webkitpy/common/net/irc/ircbot.py:
     13        * Scripts/webkitpy/common/system/logutils.py:
     14        * Scripts/webkitpy/common/system/logutils_unittest.py:
     15        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
     16        * Scripts/webkitpy/layout_tests/port/chromium.py:
     17        * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
     18        * Scripts/webkitpy/layout_tests/port/webkit.py:
     19        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
     20        * Scripts/webkitpy/tool/bot/irc_command.py:
     21        * Scripts/webkitpy/tool/bot/sheriffircbot.py:
     22        * Scripts/webkitpy/tool/commands/download.py:
     23        * Scripts/webkitpy/tool/commands/prettydiff.py:
     24        * Scripts/webkitpy/tool/commands/queries.py:
     25        * Scripts/webkitpy/tool/commands/roll.py:
     26        * Scripts/webkitpy/tool/commands/stepsequence.py:
     27        * Scripts/webkitpy/tool/commands/upload.py:
     28        * Scripts/webkitpy/tool/main.py:
     29
    1302011-02-07  James Robinson  <jamesr@chromium.org>
    231
  • trunk/Tools/Scripts/webkitpy/common/checkout/scm.py

    r77889 r77913  
    3535import shutil
    3636
     37from webkitpy.common.memoized import memoized
     38from webkitpy.common.system.deprecated_logging import error, log
    3739from webkitpy.common.system.executive import Executive, run_command, ScriptError
    38 from webkitpy.common.system.deprecated_logging import error, log
    39 import webkitpy.common.system.ospath as ospath
    40 from webkitpy.common.memoized import memoized
     40from webkitpy.common.system import ospath
    4141
    4242
  • trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py

    r56977 r77913  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
    29 import webkitpy.common.config.irc as config_irc
     29from webkitpy.common.config import irc as config_irc
    3030
    3131from webkitpy.common.thread.messagepump import MessagePump, MessagePumpDelegate
  • trunk/Tools/Scripts/webkitpy/common/system/logutils.py

    r56893 r77913  
    8484    Sample usage:
    8585
    86       import webkitpy.common.system.logutils as logutils
     86      from webkitpy.common.system import logutils
    8787
    8888      _log = logutils.get_logger(__file__)
  • trunk/Tools/Scripts/webkitpy/common/system/logutils_unittest.py

    r74301 r77913  
    2929from webkitpy.common.system.logtesting import LogTesting
    3030from webkitpy.common.system.logtesting import TestLogStream
    31 import webkitpy.common.system.logutils as logutils
     31from webkitpy.common.system import logutils
    3232
    3333
  • trunk/Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py

    r67588 r77913  
    3737import sys
    3838import re
    39 import webkitpy.common.checkout.scm as scm
    40 import webkitpy.common.system.executive as executive
    41 import webkitpy.common.system.logutils as logutils
    42 import webkitpy.common.system.ospath as ospath
    43 import webkitpy.layout_tests.port.factory as port_factory
     39
     40from webkitpy.common.checkout import scm
     41from webkitpy.common.system import executive
     42from webkitpy.common.system import logutils
     43from webkitpy.common.system import ospath
     44from webkitpy.layout_tests.port import factory as port_factory
    4445
    4546_log = logutils.get_logger(__file__)
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py

    r77603 r77913  
    4242from webkitpy.common.system.path import cygpath
    4343from webkitpy.layout_tests.layout_package import test_expectations
    44 
    45 import base
    46 import http_server
    47 import websocket_server
     44from webkitpy.layout_tests.port import base
     45from webkitpy.layout_tests.port import http_server
     46from webkitpy.layout_tests.port import websocket_server
    4847
    4948_log = logging.getLogger("webkitpy.layout_tests.port.chromium")
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py

    r77004 r77913  
    3434import signal
    3535
    36 import webkitpy.common.system.ospath as ospath
    37 import webkitpy.layout_tests.port.server_process as server_process
    38 from webkitpy.layout_tests.port.webkit import WebKitPort, WebKitDriver
     36from webkitpy.layout_tests.port.webkit import WebKitPort
    3937
    4038_log = logging.getLogger("webkitpy.layout_tests.port.mac")
  • trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

    r77603 r77913  
    4141import webbrowser
    4242
    43 import webkitpy.common.system.ospath as ospath
    44 import webkitpy.layout_tests.port.base as base
    45 import webkitpy.layout_tests.port.server_process as server_process
     43from webkitpy.common.system import ospath
     44from webkitpy.layout_tests.port import base
     45from webkitpy.layout_tests.port import server_process
    4646
    4747_log = logging.getLogger("webkitpy.layout_tests.port.webkit")
  • trunk/Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py

    r67669 r77913  
    3232import re
    3333import sys
    34 import webkitpy.common.checkout.scm as scm
     34from webkitpy.common.checkout import scm
    3535
    3636_log = logging.getLogger("webkitpy.layout_tests."
  • trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py

    r75062 r77913  
    2828
    2929import random
    30 import webkitpy.common.config.irc as config_irc
     30from webkitpy.common.config import irc as config_irc
    3131
    3232from webkitpy.common.config import urls
  • trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot.py

    r60993 r77913  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
    29 import webkitpy.tool.bot.irc_command as irc_command
     29from webkitpy.tool.bot import irc_command
    3030
    3131from webkitpy.common.net.irc.ircbot import IRCBotDelegate
  • trunk/Tools/Scripts/webkitpy/tool/commands/download.py

    r74639 r77913  
    3030import os
    3131
    32 import webkitpy.tool.steps as steps
     32from webkitpy.tool import steps
    3333
    3434from webkitpy.common.checkout.changelog import ChangeLog
  • trunk/Tools/Scripts/webkitpy/tool/commands/prettydiff.py

    r57977 r77913  
    2828
    2929from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
    30 import webkitpy.tool.steps as steps
     30from webkitpy.tool import steps
    3131
    3232
  • trunk/Tools/Scripts/webkitpy/tool/commands/queries.py

    r74927 r77913  
    3131from optparse import make_option
    3232
    33 import webkitpy.tool.steps as steps
     33from webkitpy.tool import steps
    3434
    3535from webkitpy.common.checkout.commitinfo import CommitInfo
  • trunk/Tools/Scripts/webkitpy/tool/commands/roll.py

    r76926 r77913  
    2929from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
    3030
    31 import webkitpy.tool.steps as steps
     31from webkitpy.tool import steps
    3232
    3333
  • trunk/Tools/Scripts/webkitpy/tool/commands/stepsequence.py

    r63114 r77913  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
    29 import webkitpy.tool.steps as steps
     29from webkitpy.tool import steps
    3030
     31from webkitpy.common.checkout.scm import CheckoutNeedsUpdate
     32from webkitpy.common.system.deprecated_logging import log
    3133from webkitpy.common.system.executive import ScriptError
    32 from webkitpy.common.checkout.scm import CheckoutNeedsUpdate
    3334from webkitpy.tool.bot.queueengine import QueueEngine
    34 from webkitpy.common.system.deprecated_logging import log
    3535
    3636
  • trunk/Tools/Scripts/webkitpy/tool/commands/upload.py

    r74639 r77913  
    3535from optparse import make_option
    3636
    37 import webkitpy.tool.steps as steps
     37from webkitpy.tool import steps
    3838
    3939from webkitpy.common.config.committers import CommitterList
    4040from webkitpy.common.net.bugzilla import parse_bug_id
     41from webkitpy.common.system.deprecated_logging import error, log
    4142from webkitpy.common.system.user import User
    4243from webkitpy.thirdparty.mock import Mock
    4344from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
     45from webkitpy.tool.comments import bug_comment_from_svn_revision
    4446from webkitpy.tool.grammar import pluralize, join_with_separators
    45 from webkitpy.tool.comments import bug_comment_from_svn_revision
    4647from webkitpy.tool.multicommandtool import AbstractDeclarativeCommand
    47 from webkitpy.common.system.deprecated_logging import error, log
    4848
    4949
  • trunk/Tools/Scripts/webkitpy/tool/main.py

    r76339 r77913  
    4545from webkitpy.layout_tests import port
    4646from webkitpy.tool.multicommandtool import MultiCommandTool
    47 import webkitpy.tool.commands as commands
     47from webkitpy.tool import commands
    4848
    4949
Note: See TracChangeset for help on using the changeset viewer.