Changeset 77995 in webkit

Timestamp:

Feb 8, 2011 4:55:42 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-08 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
​https://bugs.webkit.org/show_bug.cgi?id=53943

• editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
• editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.

2011-02-08 Jia Pu <​jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
​https://bugs.webkit.org/show_bug.cgi?id=53943

Test: editing/undo/undo-paste-when-caret-is-not-in-range.html

• editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt (added)
• LayoutTests/editing/undo/undo-paste-when-caret-is-not-in-range.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/VisibleSelection.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-08  Jia Pu  <jpu@apple.com>
+
+        Reviewed by Darin Adler.
+
+        VisibleSelection::setWithoutValidation() should allow caret selection.
+        https://bugs.webkit.org/show_bug.cgi?id=53943
+
+        * editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
+        * editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.
+
 2011-02-08  Yael Aharon  <yael.aharon@nokia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-08  Jia Pu  <jpu@apple.com>
+
+        Reviewed by Darin Adler.
+
+        VisibleSelection::setWithoutValidation() should allow caret selection.
+        https://bugs.webkit.org/show_bug.cgi?id=53943
+
+        Test: editing/undo/undo-paste-when-caret-is-not-in-range.html
+
+        * editing/VisibleSelection.cpp:
+        (WebCore::VisibleSelection::setWithoutValidation):
+
 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/editing/VisibleSelection.cpp

@@ -432 +432 @@
     ASSERT(!base.isNull());
     ASSERT(!extent.isNull());
-    ASSERT(base != extent);
     ASSERT(m_affinity == DOWNSTREAM);
     m_base = base;
@@ -444 +443 @@
         m_end = base;
     }
-    m_selectionType = RangeSelection;
+    m_selectionType = base == extent ? CaretSelection : RangeSelection;
 }