Changeset 78422 in webkit

Timestamp:

Feb 12, 2011 2:13:15 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
​https://bugs.webkit.org/show_bug.cgi?id=54342

Test which types of arrays work with crypto.getRandomValues.

• security/crypto-random-values-types-expected.txt: Added.
• security/crypto-random-values-types.html: Added.

2011-02-12 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should support all integer array types
​https://bugs.webkit.org/show_bug.cgi?id=54342

As discussed on whatwg, we should support all the integer array types.

Test: security/crypto-random-values-types.html

• page/Crypto.cpp: (WebCore::Crypto::getRandomValues):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/security/crypto-random-values-types-expected.txt (added)
• LayoutTests/security/crypto-random-values-types.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/Crypto.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-12  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Sam Weinig.
+
+        crypto.getRandomValues should support all integer array types
+        https://bugs.webkit.org/show_bug.cgi?id=54342
+
+        Test which types of arrays work with crypto.getRandomValues.
+
+        * security/crypto-random-values-types-expected.txt: Added.
+        * security/crypto-random-values-types.html: Added.
+
 2011-02-12  Jochen Eisinger  <jochen@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-12  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Sam Weinig.
+
+        crypto.getRandomValues should support all integer array types
+        https://bugs.webkit.org/show_bug.cgi?id=54342
+
+        As discussed on whatwg, we should support all the integer array types.
+
+        Test: security/crypto-random-values-types.html
+
+        * page/Crypto.cpp:
+        (WebCore::Crypto::getRandomValues):
+
 2011-02-12  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/page/Crypto.cpp

@@ -35 +35 @@
 #include <wtf/CryptographicallyRandomNumber.h>
 
+namespace WebCore {
 
-namespace WebCore {
+namespace {
+
+bool isIntegerArray(ArrayBufferView* array)
+{
+    return array->isByteArray()
+        || array->isUnsignedByteArray()
+        || array->isShortArray()
+        || array->isUnsignedShortArray()
+        || array->isIntArray()
+        || array->isUnsignedIntArray();
+}
+
+}
 
 Crypto::Crypto()
@@ -45 +58 @@
 {
 #if USE(OS_RANDOMNESS)
-    if (!array || !array->isUnsignedByteArray()) {
+    if (!array || !isIntegerArray(array)) {
         ec = VALIDATION_ERR;
         return;