Changeset 78435 in webkit

Timestamp:

Feb 13, 2011 11:10:27 AM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-02-13 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
​https://bugs.webkit.org/show_bug.cgi?id=54346

• security/crypto-random-values-types-expected.txt:

2011-02-13 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

crypto.getRandomValues should throw TYPE_MISMATCH_ERR
​https://bugs.webkit.org/show_bug.cgi?id=54346

As requested by Sam.

• page/Crypto.cpp: (WebCore::Crypto::getRandomValues):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/security/crypto-random-values-types-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/Crypto.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-13  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Sam Weinig.
+
+        crypto.getRandomValues should throw TYPE_MISMATCH_ERR
+        https://bugs.webkit.org/show_bug.cgi?id=54346
+
+        * security/crypto-random-values-types-expected.txt:
+
 2011-02-13  Shinichiro Hamaji  <hamaji@chromium.org>
 

trunk/LayoutTests/security/crypto-random-values-types-expected.txt

@@ -12 +12 @@
 PASS crypto.getRandomValues(new Uint32Array(3)) is undefined.
 PASS crypto.getRandomValues(new Int32Array(3)) is undefined.
-PASS crypto.getRandomValues(new Float32Array(3)) threw exception Error: VALIDATION_ERR: DOM Exception 16.
+PASS crypto.getRandomValues(new Float32Array(3)) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
 PASS successfullyParsed is true
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-13  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Sam Weinig.
+
+        crypto.getRandomValues should throw TYPE_MISMATCH_ERR
+        https://bugs.webkit.org/show_bug.cgi?id=54346
+
+        As requested by Sam.
+
+        * page/Crypto.cpp:
+        (WebCore::Crypto::getRandomValues):
+
 2011-02-13  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/page/Crypto.cpp

@@ -59 +59 @@
 #if USE(OS_RANDOMNESS)
     if (!array || !isIntegerArray(array)) {
-        ec = VALIDATION_ERR;
+        ec = TYPE_MISMATCH_ERR;
         return;
     }