Changeset 78507 in webkit


Ignore:
Timestamp:
Feb 14, 2011 2:15:49 PM (13 years ago)
Author:
dpranke@chromium.org
Message:

2011-02-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

This patch updates NRWT to add per-worker and per-shard test stats
into TestRunner2, bringing it to parity with TestRunner.

https://bugs.webkit.org/show_bug.cgi?id=54074

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r78506 r78507  
     12011-02-14  Dirk Pranke  <dpranke@chromium.org>
     2
     3        Reviewed by Ojan Vafai.
     4
     5        This patch updates NRWT to add per-worker and per-shard test stats
     6        into TestRunner2, bringing it to parity with TestRunner.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=54074
     9
     10        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
     11
    1122011-02-14  Dirk Pranke  <dpranke@chromium.org>
    213
  • trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py

    r78506 r78507  
    4343from webkitpy.layout_tests.layout_package import worker
    4444
     45
    4546_log = logging.getLogger(__name__)
    4647
     
    5657        self.next_timeout = None
    5758        self.wedged = False
     59        self.stats = {}
     60        self.stats['name'] = worker_connection.name
     61        self.stats['num_tests'] = 0
     62        self.stats['total_time'] = 0
    5863
    5964    def __repr__(self):
     
    109114        self._current_result_summary = result_summary
    110115        self._all_results = []
     116        self._group_stats = {}
    111117        self._worker_states = {}
    112118
     
    134140            time.sleep(0.1)
    135141
     142        self._printer.print_update("Starting testing ...")
    136143        for test_list in test_lists:
    137144            manager_connection.post_message('test_list', test_list[0], test_list[1])
     
    178185            raise
    179186
    180 
    181         # FIXME: implement stats.
    182 
    183         thread_timings = []
     187        thread_timings = [worker_state.stats for worker_state in self._worker_states.values()]
    184188
    185189        # FIXME: should this be a class instead of a tuple?
     
    204208
    205209    def handle_finished_list(self, source, list_name, num_tests, elapsed_time):
    206         # FIXME: update stats
    207         pass
     210        self._group_stats[list_name] = (num_tests, elapsed_time)
    208211
    209212    def handle_finished_test(self, source, result, elapsed_time):
     
    211214        worker_state.next_timeout = None
    212215        worker_state.current_test_name = None
     216        worker_state.stats['total_time'] += elapsed_time
     217        worker_state.stats['num_tests'] += 1
    213218
    214219        if worker_state.wedged:
     
    216221            _log.error("%s unwedged", w.name)
    217222
     223        self._all_results.append(result)
    218224        self._update_summary_with_result(self._current_result_summary, result)
    219 
    220         # FIXME: update stats.
    221         self._all_results.append(result)
Note: See TracChangeset for help on using the changeset viewer.