Changeset 78689 in webkit


Ignore:
Timestamp:
Feb 16, 2011 3:10:13 AM (13 years ago)
Author:
Philippe Normand
Message:

2011-02-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] wrong media duration report in media/controls-after-reload.html
​https://bugs.webkit.org/show_bug.cgi?id=51602

Refactored some media tests to be less flaky-prone.

  • media/controls-after-reload.html: Trigger playback just before rendering the controls.
  • media/video-paint-test.js: Ditto. (init.document.addEventListener.): (init):
  • media/video-volume-slider.html: Trigger DRT dump after volume was updated.
  • platform/gtk/Skipped: Unskip fixed tests.
  • platform/gtk/media/video-controls-rendering-expected.txt:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r78682 r78689  
     12011-02-15  Philippe Normand  <pnormand@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GStreamer] wrong media duration report in media/controls-after-reload.html
     6        https://bugs.webkit.org/show_bug.cgi?id=51602
     7
     8        Refactored some media tests to be less flaky-prone.
     9
     10        * media/controls-after-reload.html: Trigger playback just before
     11        rendering the controls.
     12        * media/video-paint-test.js: Ditto.
     13        (init.document.addEventListener.):
     14        (init):
     15        * media/video-volume-slider.html: Trigger DRT dump after volume
     16        was updated.
     17        * platform/gtk/Skipped: Unskip fixed tests.
     18        * platform/gtk/media/video-controls-rendering-expected.txt:
     19
    1202011-02-15  Kent Tamura  <tkent@chromium.org>
    221

  • trunk/LayoutTests/media/controls-after-reload.html

    r48694 r78689  
    99        layoutTestController.waitUntilDone();
    1010
     11    function finish()
     12    {
     13        if (window.layoutTestController)
     14            layoutTestController.notifyDone();
     15    }
     16
    1117    function canplaythrough()
    1218    {
     19        if (!loadedCount) {
     20            video.src = findMediaFile("video", "content/test");
     21            video.load();
     22            video.play();
     23            video.addEventListener("playing", finish);
     24        }
    1325        loadedCount++;
    14         if (loadedCount == 2) {
    15             if (window.layoutTestController)
    16                 layoutTestController.notifyDone();
    17             return;
    18         }
    19        
    20         video.src = findMediaFile("video", "content/test");
    21         video.load();
    2226    }
    2327

  • trunk/LayoutTests/media/video-paint-test.js

    r39120 r78689  
    55    document.addEventListener("canplaythrough", function () {
    66        if (!--count) {
     7            var video = document.getElementsByTagName('video')[0];
     8            if (window.layoutTestController) {
     9                video.play();
     10                video.addEventListener("playing", function() { layoutTestController.notifyDone(); });
     11            }
    712            document.body.offsetLeft;
    8             if (window.layoutTestController)
    9                 setTimeout(function() { layoutTestController.notifyDone(); }, totalCount * 100);
    1013        }
    1114    }, true);

  • trunk/LayoutTests/media/video-volume-slider.html

    r49995 r78689  
    2525            }
    2626
    27             if (window.layoutTestController)
    28                 layoutTestController.notifyDone();
     27            video.addEventListener("volumechange", function() {
     28                 if (window.layoutTestController)
     29                     layoutTestController.notifyDone();
     30            });
    2931        }
    3032    </script>

  • trunk/LayoutTests/platform/gtk/Skipped

    r78677 r78689  
    345345media/video-source-error.html
    346346
    347 # https://bugs.webkit.org/show_bug.cgi?id=51602
    348 media/controls-after-reload.html
    349 media/controls-strict.html
    350347media/video-display-toggle.html
    351 media/controls-styling.html
    352 media/video-volume-slider.html
    353 media/video-controls-rendering.html
    354348
    355349#   Tests generating new results

  • trunk/LayoutTests/platform/gtk/media/video-controls-rendering-expected.txt

    r75798 r78689  
    2727            text run at (5,5) width 55: "00:00 / 00:06"
    2828      RenderSlider {INPUT} at (66,0) size 153x20
    29         RenderBlock {DIV} at (2,4) size 12x12
     29        RenderBlock {DIV} at (7,4) size 12x12
    3030    RenderButton {INPUT} at (240,220) size 20x20
    3131    RenderButton {INPUT} at (260,220) size 20x20
Note: See TracChangeset for help on using the changeset viewer.