Changeset 78690 in webkit


Ignore:
Timestamp:
Feb 16, 2011 3:13:24 AM (13 years ago)
Author:
Philippe Normand
Message:

2011-02-15 Philippe Normand <​pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] media/controls-without-preload.html is flacky on 32-bits Debug
​https://bugs.webkit.org/show_bug.cgi?id=50518

Refactored 2 media tests to avoid use of setTimeout and possible
flakyness.

  • media/controls-without-preload.html:
  • media/video-display-toggle.html:
  • platform/gtk/Skipped:
  • platform/gtk/media/controls-without-preload-expected.txt:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r78689 r78690  
     12011-02-15  Philippe Normand  <pnormand@igalia.com>
     2
     3        Reviewed by Martin Robinson.
     4
     5        [GTK] media/controls-without-preload.html is flacky on 32-bits Debug
     6        https://bugs.webkit.org/show_bug.cgi?id=50518
     7
     8        Refactored 2 media tests to avoid use of setTimeout and possible
     9        flakyness.
     10
     11        * media/controls-without-preload.html:
     12        * media/video-display-toggle.html:
     13        * platform/gtk/Skipped:
     14        * platform/gtk/media/controls-without-preload-expected.txt:
     15
    1162011-02-15  Philippe Normand  <pnormand@igalia.com>
    217

  • trunk/LayoutTests/media/controls-without-preload.html

    r73257 r78690  
    99            {
    1010                setSrcByTagName("video", findMediaFile("video", "content/test"));
    11                 setTimeout(finish, 200);
     11                video = document.getElementsByTagName('video')[0];
     12                video.load();
     13                video.play();
     14                video.addEventListener("canplaythrough", finish);
    1215            }
    1316

  • trunk/LayoutTests/media/video-display-toggle.html

    r48494 r78690  
    66            {
    77                var video = document.getElementById('vid');
    8                 if (video.style.display == "none")
     8                if (video.style.display == "none") {
    99                    video.style.display = "inline-block";
    10                 else
     10                    if (window.layoutTestController)
     11                        layoutTestController.notifyDone();
     12                } else
    1113                    video.style.display = "none";
    1214                document.body.offsetLeft;
    … …  
    2325                toggleDisplay();
    2426                toggleDisplay();
    25 
    26                 if (window.layoutTestController)
    27                     setTimeout(function() { layoutTestController.notifyDone(); }, 100);
    2827            }
    2928        </script>

  • trunk/LayoutTests/platform/gtk/Skipped

    r78689 r78690  
    344344# https://bugs.webkit.org/show_bug.cgi?id=30198
    345345media/video-source-error.html
    346 
    347 media/video-display-toggle.html
    348346
    349347#   Tests generating new results
    … …  
    22762274media/controls-drag-timebar.html
    22772275
    2278 # https://bugs.webkit.org/show_bug.cgi?id=50518
    2279 media/controls-without-preload.html
    2280 
    22812276# https://bugs.webkit.org/show_bug.cgi?id=50740
    22822277editing/spelling/spelling-backspace-between-lines.html

  • trunk/LayoutTests/platform/gtk/media/controls-without-preload-expected.txt

    r73257 r78690  
    77        RenderText {#text} at (0,0) size 312x19
    88          text run at (0,0) width 312: "The controls should not depend on preload value."
    9       RenderBlock (anonymous) at (0,35) size 784x150
     9      RenderBlock (anonymous) at (0,35) size 784x240
    1010        RenderText {#text} at (0,0) size 0x0
    11 layer at (8,43) size 300x150
    12   RenderVideo {VIDEO} at (0,0) size 300x150
    13 layer at (8,43) size 300x150
    14   RenderBlock (relative positioned) {DIV} at (0,0) size 300x150
    15 layer at (8,173) size 300x20
    16   RenderFlexibleBox (positioned) {DIV} at (0,130) size 300x20
    17     RenderButton {INPUT} at (0,0) size 20x20
    18     RenderFlexibleBox {DIV} at (20,0) size 200x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)]
    19       RenderSlider {INPUT} at (1,0) size 198x20
     11layer at (8,43) size 320x240
     12  RenderVideo {VIDEO} at (0,0) size 320x240
     13layer at (8,43) size 320x240
     14  RenderBlock (relative positioned) {DIV} at (0,0) size 320x240
     15layer at (8,43) size 320x240 scrollHeight 250
     16  RenderFlexibleBox (positioned) {DIV} at (0,0) size 320x240
     17    RenderButton {INPUT} at (0,220) size 20x20
     18    RenderFlexibleBox {DIV} at (20,220) size 220x20 [border: (1px solid #FFFFFF33) none (1px solid #FFFFFF33)]
     19      RenderBlock (anonymous) at (1,0) size 65x30
     20        RenderBlock {DIV} at (0,0) size 65x30
     21          RenderText {#text} at (5,5) size 55x12
     22            text run at (5,5) width 55: "00:00 / 00:06"
     23      RenderSlider {INPUT} at (66,0) size 153x20
    2024        RenderBlock {DIV} at (2,4) size 12x12
    21     RenderButton {INPUT} at (220,0) size 20x20
    22     RenderButton {INPUT} at (240,0) size 20x20
    23     RenderButton {INPUT} at (260,0) size 20x20
    24     RenderButton {INPUT} at (280,0) size 20x20
     25    RenderButton {INPUT} at (240,220) size 20x20
     26    RenderButton {INPUT} at (260,220) size 20x20
     27    RenderButton {INPUT} at (280,220) size 20x20
     28    RenderButton {INPUT} at (300,220) size 20x20
Note: See TracChangeset for help on using the changeset viewer.