Changeset 79060 in webkit

Timestamp:

Feb 18, 2011 5:43:40 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-18 chris reiss <​christopher.reiss@nokia.com>

Reviewed by Andreas Kling.

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
​https://bugs.webkit.org/show_bug.cgi?id=49989

• fast/js/date-parse-test-expected.txt:
• fast/js/script-tests/date-parse-test.js:

2011-02-18 chris reiss <​christopher.reiss@nokia.com>

Reviewed by Andreas Kling.

REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
​https://bugs.webkit.org/show_bug.cgi?id=49989

updated test fast/js/script-tests/date-parse-test.js

• wtf/DateMath.cpp: (WTF::parseDateFromNullTerminatedCharacters):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/date-parse-test-expected.txt (modified) (1 diff)
• LayoutTests/fast/js/script-tests/date-parse-test.js (modified) (2 diffs)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/wtf/DateMath.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-18  chris reiss  <christopher.reiss@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
+        https://bugs.webkit.org/show_bug.cgi?id=49989
+
+        * fast/js/date-parse-test-expected.txt:
+        * fast/js/script-tests/date-parse-test.js:
+
 2011-02-18  Emil A Eklund  <eae@chromium.org>
 

trunk/LayoutTests/fast/js/date-parse-test-expected.txt

@@ -162 +162 @@
 PASS Date.parse("WED DEC 25 1995 1:30 GMT") == 819855000000 is true
 PASS Date.parse("wed dec 25 1995 1:30 gmt") == 819855000000 is true
+PASS Date.parse("Wed Dec 25 1:30 1995 GMT") == 819855000000 is true
+PASS Date.parse("WED DEC 25 1:30 1995 GMT") == 819855000000 is true
+PASS Date.parse("wed dec 25 1:30 1995 gmt") == 819855000000 is true
+PASS Date.parse("Wed Dec 25 1:30 1995GMT") == 819855000000 is true
+PASS Date.parse("Wed Dec 25 1:30 1995 2010 GMT") is NaN
+PASS Date.parse("Wed Dec 25 1:30 1995r GMT") is NaN
+PASS Date.parse("Wed 1:30 Dec 25 GMT") is NaN
 PASS Date.parse("Dec 25" + String.fromCharCode(9) + "1995 13:30 GMT") == 819898200000 is true
 PASS Date.parse(("Dec 25" + String.fromCharCode(9) + "1995 13:30 GMT").toUpperCase()) == 819898200000 is true

trunk/LayoutTests/fast/js/script-tests/date-parse-test.js

@@ -128 +128 @@
 
 testDateParse("Wed Dec 25 1995 1:30 GMT", "819855000000");
+testDateParse("Wed Dec 25 1:30 1995 GMT", "819855000000");
+testDateParseExact("Wed Dec 25 1:30 1995GMT", "819855000000");
+testDateParseExact("Wed Dec 25 1:30 1995 2010 GMT", "NaN");
+testDateParseExact("Wed Dec 25 1:30 1995r GMT", "NaN");
+testDateParseExact("Wed 1:30 Dec 25 GMT", "NaN");
 
 testDateParseExpr('"Dec 25" + String.fromCharCode(9) + "1995 13:30 GMT"', "819898200000");
@@ -142 +147 @@
 testDateParse("Dec 25,1995,13:30", "819898200000 + timeZoneOffset");
 
+
+
 var successfullyParsed = true;

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-02-18  chris reiss  <christopher.reiss@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        REGRESSION: Date.parse("Tue Nov 23 20:40:05 2010 GMT") returns NaN
+        https://bugs.webkit.org/show_bug.cgi?id=49989
+
+        updated test fast/js/script-tests/date-parse-test.js
+
+        * wtf/DateMath.cpp:
+        (WTF::parseDateFromNullTerminatedCharacters):
+
 2011-02-18  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/JavaScriptCore/wtf/DateMath.cpp

@@ -921 +921 @@
         }
     }
+    
+    // The year may be after the time but before the time zone.
+    if (year <= 0) {
+       if (!parseLong(dateString, &newPosStr, 10, &year))
+          year = 0;
+       dateString = newPosStr;
+       skipSpacesAndComments(dateString);
+    }
 
     // Don't fail if the time zone is missing.