Changeset 79166 in webkit
- Timestamp:
- Feb 20, 2011 6:45:29 PM (13 years ago)
- Location:
- trunk/Websites/bugs.webkit.org
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Websites/bugs.webkit.org/ChangeLog
r79165 r79166 1 2011-02-17 Ojan Vafai <ojan@chromium.org> 2 3 Reviewed by Adam Barth. 4 5 use shift+j/k to focus next/previous line 6 https://bugs.webkit.org/show_bug.cgi?id=54723 7 8 Tested on a large Hyatt change to confirm it performed fine. 9 (https://bugs.webkit.org/attachment.cgi?id=82533&action=review) 10 11 * code-review.js: 12 1 13 2011-02-17 Ojan Vafai <ojan@chromium.org> 2 14 -
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
r79163 r79166 448 448 </style> 449 449 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 450 <script src="code-review.js?version=3 5"></script>450 <script src="code-review.js?version=36"></script> 451 451 EOF 452 452 -
trunk/Websites/bugs.webkit.org/code-review.js
r79165 r79166 1350 1350 1351 1351 function focusNext(filter, direction) { 1352 var focusable_nodes = $('a,. frozenComment,.previousComment,.DiffBlock,.overallComments').filter(function() {1352 var focusable_nodes = $('a,.Line,.frozenComment,.previousComment,.DiffBlock,.overallComments').filter(function() { 1353 1353 return !$(this).hasClass('DiffBlock') || $('.add,.remove', this).size(); 1354 1354 }); … … 1377 1377 var kCharCodeForJ = 'j'.charCodeAt(0); 1378 1378 var kCharCodeForK = 'k'.charCodeAt(0); 1379 var kCharCodeForCapitalJ = 'J'.charCodeAt(0); 1380 var kCharCodeForCapitalK = 'K'.charCodeAt(0); 1379 1381 var kCharCodeForEnter = '\r'.charCodeAt(0); 1380 1382 … … 1385 1387 function isDiffBlock(node) { 1386 1388 return node.hasClass('DiffBlock'); 1389 } 1390 1391 function isLine(node) { 1392 return node.hasClass('Line'); 1387 1393 } 1388 1394 … … 1416 1422 case kCharCodeForK: 1417 1423 handled = focusNext(isDiffBlock, DIRECTION.BACKWARD); 1424 break; 1425 1426 case kCharCodeForCapitalJ: 1427 handled = focusNext(isLine, DIRECTION.FORWARD); 1428 break; 1429 1430 case kCharCodeForCapitalK: 1431 handled = focusNext(isLine, DIRECTION.BACKWARD); 1418 1432 break; 1419 1433
Note: See TracChangeset
for help on using the changeset viewer.