Changeset 79166 in webkit


Ignore:
Timestamp:
Feb 20, 2011 6:45:29 PM (13 years ago)
Author:
ojan@chromium.org
Message:

2011-02-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

use shift+j/k to focus next/previous line
https://bugs.webkit.org/show_bug.cgi?id=54723

Tested on a large Hyatt change to confirm it performed fine.
(https://bugs.webkit.org/attachment.cgi?id=82533&action=review)

  • code-review.js:
Location:
trunk/Websites/bugs.webkit.org
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Websites/bugs.webkit.org/ChangeLog

    r79165 r79166  
     12011-02-17  Ojan Vafai  <ojan@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        use shift+j/k to focus next/previous line
     6        https://bugs.webkit.org/show_bug.cgi?id=54723
     7
     8        Tested on a large Hyatt change to confirm it performed fine.
     9        (https://bugs.webkit.org/attachment.cgi?id=82533&action=review)
     10
     11        * code-review.js:
     12
    1132011-02-17  Ojan Vafai  <ojan@chromium.org>
    214
  • trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb

    r79163 r79166  
    448448</style>
    449449<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>
    450 <script src="code-review.js?version=35"></script>
     450<script src="code-review.js?version=36"></script>
    451451EOF
    452452
  • trunk/Websites/bugs.webkit.org/code-review.js

    r79165 r79166  
    13501350
    13511351  function focusNext(filter, direction) {
    1352     var focusable_nodes = $('a,.frozenComment,.previousComment,.DiffBlock,.overallComments').filter(function() {
     1352    var focusable_nodes = $('a,.Line,.frozenComment,.previousComment,.DiffBlock,.overallComments').filter(function() {
    13531353      return !$(this).hasClass('DiffBlock') || $('.add,.remove', this).size();
    13541354    });
     
    13771377  var kCharCodeForJ = 'j'.charCodeAt(0);
    13781378  var kCharCodeForK = 'k'.charCodeAt(0);
     1379  var kCharCodeForCapitalJ = 'J'.charCodeAt(0);
     1380  var kCharCodeForCapitalK = 'K'.charCodeAt(0);
    13791381  var kCharCodeForEnter = '\r'.charCodeAt(0);
    13801382
     
    13851387  function isDiffBlock(node) {
    13861388    return node.hasClass('DiffBlock');
     1389  }
     1390 
     1391  function isLine(node) {
     1392    return node.hasClass('Line');
    13871393  }
    13881394
     
    14161422    case kCharCodeForK:
    14171423      handled = focusNext(isDiffBlock, DIRECTION.BACKWARD);
     1424      break;
     1425     
     1426    case kCharCodeForCapitalJ:
     1427      handled = focusNext(isLine, DIRECTION.FORWARD);
     1428      break;
     1429
     1430    case kCharCodeForCapitalK:
     1431      handled = focusNext(isLine, DIRECTION.BACKWARD);
    14181432      break;
    14191433   
Note: See TracChangeset for help on using the changeset viewer.