Changeset 79295 in webkit


Ignore:
Timestamp:
Feb 21, 2011 11:21:09 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
https://bugs.webkit.org/show_bug.cgi?id=54806

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): spatial navigation setting initialization added

2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
https://bugs.webkit.org/show_bug.cgi?id=54806

  • EWebLauncher/main.c: (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/efl/ChangeLog

    r79171 r79295  
     12011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        [EFL] Fixed missing spatial navigation setting initialization. Doxygen comments added.
     6        https://bugs.webkit.org/show_bug.cgi?id=54806
     7
     8        * ewk/ewk_view.cpp:
     9        (_ewk_view_priv_new): spatial navigation setting initialization added
     10
    1112011-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    212
  • trunk/Source/WebKit/efl/ewk/ewk_view.cpp

    r79067 r79295  
    11/*
    22    Copyright (C) 2009-2010 ProFUSION embedded systems
    3     Copyright (C) 2009-2010 Samsung Electronics
     3    Copyright (C) 2009-2011 Samsung Electronics
    44
    55    This library is free software; you can redistribute it and/or
     
    619619    priv->settings.private_browsing = priv->page_settings->privateBrowsingEnabled();
    620620    priv->settings.caret_browsing = priv->page_settings->caretBrowsingEnabled();
     621    priv->settings.spatial_navigation = priv->page_settings->isSpatialNavigationEnabled();
    621622    priv->settings.local_storage = priv->page_settings->localStorageEnabled();
    622623    priv->settings.offline_app_cache = true; // XXX no function to read setting; this keeps the original setting
     
    29192920}
    29202921
     2922/**
     2923 * Gets if the spatial naviagtion is enabled.
     2924 *
     2925 * @param o view object to get spatial navigation setting.
     2926 * @return @c EINA_TRUE if spatial navigation is enabled, @c EINA_FALSE if not or on errors.
     2927 */
    29212928Eina_Bool ewk_view_setting_spatial_navigation_get(Evas_Object* o)
    29222929{
     
    29262933}
    29272934
     2935/**
     2936 * Sets the spatial navigation.
     2937 *
     2938 * @param o view object to set spatial navigation setting.
     2939 * @return @c EINA_TRUE on success and @c EINA_FALSE on failure
     2940 */
    29282941Eina_Bool ewk_view_setting_spatial_navigation_set(Evas_Object* o, Eina_Bool enable)
    29292942{
  • trunk/Tools/ChangeLog

    r79279 r79295  
     12011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>
     2
     3        Reviewed by Antonio Gomes.
     4
     5        [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
     6        https://bugs.webkit.org/show_bug.cgi?id=54806
     7
     8        * EWebLauncher/main.c:
     9        (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
     10
    1112011-02-21  Dirk Pranke  <dpranke@chromium.org>
    212
  • trunk/Tools/EWebLauncher/main.c

    r74640 r79295  
    569569        info("Stop (F6) was pressed, stop loading.\n");
    570570        ewk_view_stop(obj);
    571     /* } FIXME: uncomment code below after Bug 18662 lands upstream.
    572     else if (!strcmp(ev->key, "F12")) {
    573         bool status = ewk_webframe_object_keyboard_navigation_get(page);
    574         ewk_webframe_object_keyboard_navigation_set(page, !status);
    575         info("Command::keyboard navigation toggle\n");*/
     571    } else if (!strcmp(ev->key, "F12")) {
     572        Eina_Bool status = ewk_view_setting_spatial_navigation_get(obj);
     573        ewk_view_setting_spatial_navigation_set(obj, !status);
     574        info("Command::keyboard navigation toggle\n");
    576575    } else if (!strcmp(ev->key, "F7")) {
    577576        info("Zoom out (F7) was pressed.\n");
Note: See TracChangeset for help on using the changeset viewer.