Changeset 79329 in webkit

Timestamp:

Feb 22, 2011 9:39:35 AM (13 years ago)

Author:

Martin Robinson

Message:

2011-02-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
​https://bugs.webkit.org/show_bug.cgi?id=53603

• platform/gtk/Skipped: Unskip passing tests.

2011-02-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
​https://bugs.webkit.org/show_bug.cgi?id=53603

Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
listens to this value during DRT runs. Perhaps later we can expose this to the public
API.

• WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
• WebCoreSupport/DumpRenderTreeSupportGtk.h:
• WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk for the appropriate return value.

2011-02-02 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
​https://bugs.webkit.org/show_bug.cgi?id=53603

Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
to DumpRenderTreeSupportGtk for this functionality.

• DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to false when reseting values between tests.
• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace with the appropriate value.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/Skipped (modified) (2 diffs)
• Source/WebKit/gtk/ChangeLog (modified) (1 diff)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (modified) (2 diffs)
• Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h (modified) (2 diffs)
• Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (1 diff)
• Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-02  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
+        https://bugs.webkit.org/show_bug.cgi?id=53603
+
+        * platform/gtk/Skipped: Unskip passing tests.
+
 2011-02-22  Adam Roben  <aroben@apple.com>
 

trunk/LayoutTests/platform/gtk/Skipped

@@ -1142 +1142 @@
 editing/pasteboard/smart-drag-drop.html
 editing/selection/drag-start-event-client-x-y.html
-editing/selection/doubleclick-beside-cr-span.html
 
 # Fails because multiple clicks in a row in the same place
@@ -1315 +1314 @@
 http/tests/security/local-user-CSS-from-remote.html
 
-# Need an implementation of setSelectTrailingWhitespace
-# https://bugs.webkit.org/show_bug.cgi?id=53603
-editing/selection/doubleclick-whitespace.html
-
 # Need an implementation of PlainTextController
 # https://bugs.webkit.org/show_bug.cgi?id=53605

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2011-02-02  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
+        https://bugs.webkit.org/show_bug.cgi?id=53603
+
+        Add setSelectTrailingWhitespaceEnabled and selectTrailingWhitespaceEnabled which allow
+        setting and querying the selectTrailingWhitespaceEnabled setting. EditorClient just
+        listens to this value during DRT runs. Perhaps later we can expose this to the public
+        API.
+
+        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+        (DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled): Added
+        (DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled): Added
+        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
+        * WebCoreSupport/EditorClientGtk.cpp:
+        (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled): Ask DRTSupportGtk
+        for the appropriate return value.
+
 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp

@@ -70 +70 @@
 bool DumpRenderTreeSupportGtk::s_drtRun = false;
 bool DumpRenderTreeSupportGtk::s_linksIncludedInTabChain = true;
+bool DumpRenderTreeSupportGtk::s_selectTrailingWhitespaceEnabled = false;
 
 DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk()
@@ -101 +102 @@
 {
     WebKit::setIconDatabaseEnabled(enabled);
+}
+
+void DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled(bool enabled)
+{
+    s_selectTrailingWhitespaceEnabled = enabled;
+}
+
+bool DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled()
+{
+    return s_selectTrailingWhitespaceEnabled;
 }
 

trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h

@@ -55 +55 @@
     static bool linksIncludedInFocusChain();
     static void setIconDatabaseEnabled(bool);
+    static void setSelectTrailingWhitespaceEnabled(bool);
+    static bool selectTrailingWhitespaceEnabled();
+
     static JSValueRef nodesFromRect(JSContextRef context, JSValueRef value, int x, int y, unsigned top, unsigned right, unsigned bottom, unsigned left, bool ignoreClipping);
     static void dumpConfigurationForViewport(WebKitWebView* webView, gint availableWidth, gint availableHeight);
@@ -106 +109 @@
     static bool s_drtRun;
     static bool s_linksIncludedInTabChain;
+    static bool s_selectTrailingWhitespaceEnabled;
 };
 

trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp

@@ -26 +26 @@
 
 #include "DataObjectGtk.h"
+#include "DumpRenderTreeSupportGtk.h"
 #include "EditCommand.h"
 #include "Editor.h"
@@ -572 +573 @@
 bool EditorClient::isSelectTrailingWhitespaceEnabled()
 {
-    notImplemented();
-    return false;
+    if (!DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled())
+        return false;
+    return DumpRenderTreeSupportGtk::selectTrailingWhitespaceEnabled();
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2011-02-02  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
+        https://bugs.webkit.org/show_bug.cgi?id=53603
+
+        Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
+        to DumpRenderTreeSupportGtk for this functionality.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
+        false when reseting values between tests.
+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+        (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
+        with the appropriate value.
+
 2011-02-22  Adam Roben  <aroben@apple.com>
 

trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -455 +455 @@
     DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain(true);
     DumpRenderTreeSupportGtk::setIconDatabaseEnabled(false);
+    DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled(false);
 
     if (axController)

trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

@@ -509 +509 @@
 void LayoutTestController::setSelectTrailingWhitespaceEnabled(bool flag)
 {
-    // FIXME: implement
+    DumpRenderTreeSupportGtk::setSelectTrailingWhitespaceEnabled(flag);
 }