Changeset 79451 in webkit

Timestamp:

Feb 23, 2011 9:10:33 AM (13 years ago)

Author:

mitz@apple.com

Message:

Fix two issues seen in WebKit2 views on Mac:

• <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
• <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text

Reviewed by Maciej Stachowiak.

• page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
to -1. Since WebKit2 doesn't support non-activating clicks yet (<​http://webkit.org/b/55053>
<rdar://problem/9042197>) and doesn't send event numbers, all events were considered to be
window-activating events. This in turn prevented them from clearing the selection and resuming
caret blinking on mouse up.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (9 diffs)
• page/EventHandler.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-23  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        Fix two issues seen in WebKit2 views on Mac:
+        - <rdar://problem/8867831> WebKit2: Insertion points in form fields no longer blink
+        - <rdar://problem/8950362> REGRESSION (WebKit2): Cannot deselect text
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::EventHandler): Initialize m_activationEventNumber
+        to -1. Since WebKit2 doesnÕt support non-activating clicks yet (<http://webkit.org/b/55053>
+        <rdar://problem/9042197>) and doesnÕt send event numbers, all events were considered to be
+        window-activating events. This in turn prevented them from clearing the selection and resuming
+        caret blinking on mouse up.
+
 2011-02-23  Jacob Dinu  <dinu.jacob@nokia.com>
 
@@ -494 +509 @@
 2011-02-22  Chang Shu  <cshu@webkit.org>
 
-        Reviewed by Csaba Osztrogonác.
+        Reviewed by Csaba Osztrogonác.
 
         [Qt] editing/deleting/5408255.html fails
@@ -563 +578 @@
 2011-02-22  Andras Becsi  <abecsi@webkit.org>
 
-        Reviewed by Csaba Osztrogonác.
+        Reviewed by Csaba Osztrogonác.
 
         [Qt] Redesign the build system
@@ -688 +703 @@
 
         Reviewed by Laszlo Gombos.
-        Rubber-stamped by Csaba Osztrogonác.
+        Rubber-stamped by Csaba Osztrogonác.
 
         [Qt] Redesign the build system
@@ -1625 +1640 @@
         (WebCore::InspectorDOMAgent::create):
 
-2011-02-21  Csaba Osztrogonác  <ossy@webkit.org>
+2011-02-21  Csaba Osztrogonác  <ossy@webkit.org>
 
         Reviewed by Andreas Kling.
@@ -2402 +2417 @@
 2011-02-18  Yi Shen  <yi.4.shen@nokia.com>
 
-        Reviewed by Tor Arne Vestbø.
+        Reviewed by Tor Arne Vestbø.
 
         Always display the media controls when requiresFullscreenForVideoPlayback() is true
@@ -3041 +3056 @@
         (WebCore::DateComponents::parseTime):
 
-2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
+2011-02-18  Csaba Osztrogonác  <ossy@webkit.org>
 
         Rubber-stamped by Andreas Kling.
@@ -3236 +3251 @@
         * page/FrameView.cpp:
         (WebCore::FrameView::scrollXForFixedPosition): Moved from ScrollView here and changed to
-        account for page scale: when the page is scaled, the “viewport” with respect to which fixed
-        objects are positioned is scaled as well. Since it’s now bigger than the real viewport (that is,
+        account for page scale: when the page is scaled, the “viewport” with respect to which fixed
+        objects are positioned is scaled as well. Since it’s now bigger than the real viewport (that is,
         the frame view), we move it around in proportion to the document scroll, so that when the document
         is fully scrolled to the bottom-right, the bottom right of the scaled viewport is visible.
@@ -3893 +3908 @@
         (WebCore::RenderSVGResourcePattern::createTileImage):
 
-2011-02-17  Csaba Osztrogonác  <ossy@webkit.org>
+2011-02-17  Csaba Osztrogonác  <ossy@webkit.org>
 
         Unreviewed.

trunk/Source/WebCore/page/EventHandler.cpp

@@ -197 +197 @@
     , m_mouseDownView(nil)
     , m_sendingEventToSubview(false)
-    , m_activationEventNumber(0)
+    , m_activationEventNumber(-1)
 #endif
 #if ENABLE(TOUCH_EVENTS)