Changeset 79781 in webkit

Timestamp:

Feb 26, 2011 5:59:36 AM (13 years ago)

Author:

eric@webkit.org

Message:

2011-02-26 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej Stachowiak.

malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
​https://bugs.webkit.org/show_bug.cgi?id=55204

• dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
  • Using an inlineCapacity of 10 for now. We may want to tweak it later.
  • This removes yet another malloc from code which removes nodes (which is rather common).

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSCSSStyleDeclarationCustom.cpp (modified) (1 diff)
• dom/ContainerNode.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-26  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Maciej Stachowiak.
+
+        malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
+        https://bugs.webkit.org/show_bug.cgi?id=55204
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::removeChildren):
+         - Using an inlineCapacity of 10 for now. We may want to tweak it later.
+         - This removes yet another malloc from code which removes nodes (which is rather common).
+
 2011-02-26  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp

@@ -136 +136 @@
 static bool isCSSPropertyName(const Identifier& propertyName)
 {
+    // FIXME: This mallocs a string for the property name and then throws it
+    // away.  This shows up on peacekeeper's domDynamicCreationCreateElement.
     return CSSStyleDeclaration::isPropertyName(cssPropertyName(propertyName));
 }

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -356 +356 @@
 void ContainerNode::willRemove()
 {
-    NodeVector nodes;
+    Vector<RefPtr<Node>, 10> nodes;
+    nodes.reserveInitialCapacity(childNodeCount());
     for (Node* n = m_lastChild; n; n = n->previousSibling())
         nodes.append(n);
@@ -513 +514 @@
 
     forbidEventDispatch();
-    Vector<RefPtr<Node> > removedChildren;
+    Vector<RefPtr<Node>, 10> removedChildren;
+    removedChildren.reserveInitialCapacity(childNodeCount());
     while (RefPtr<Node> n = m_firstChild) {
         Node* next = n->nextSibling();
-        
+
         // Remove the node from the tree before calling detach or removedFromDocument (4427024, 4129744).
         // removeChild() does this after calling detach(). There is no explanation for