Changeset 79810 in webkit

Timestamp:

Feb 26, 2011 2:40:36 PM (13 years ago)

Author:

jschuh@chromium.org

Message:

2011-02-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
​https://bugs.webkit.org/show_bug.cgi?id=55199

• fast/dom/attribute-change-on-mutate-expected.txt: Added.
• fast/dom/attribute-change-on-mutate.html: Added.

2011-02-26 Justin Schuh <​jschuh@chromium.org>

Reviewed by Darin Adler.

Delay firing of mutation events while setting attribute values
​https://bugs.webkit.org/show_bug.cgi?id=55199

Test: fast/dom/attribute-change-on-mutate.html

• dom/Attr.cpp: (WebCore::Attr::setValue):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/attribute-change-on-mutate-expected.txt (added)
• LayoutTests/fast/dom/attribute-change-on-mutate.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Attr.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-26  Justin Schuh  <jschuh@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Delay firing of mutation events while setting attribute values
+        https://bugs.webkit.org/show_bug.cgi?id=55199
+
+        * fast/dom/attribute-change-on-mutate-expected.txt: Added.
+        * fast/dom/attribute-change-on-mutate.html: Added.
+
 2011-02-25  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-26  Justin Schuh  <jschuh@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Delay firing of mutation events while setting attribute values
+        https://bugs.webkit.org/show_bug.cgi?id=55199
+
+        Test: fast/dom/attribute-change-on-mutate.html
+
+        * dom/Attr.cpp:
+        (WebCore::Attr::setValue):
+
 2011-02-26  Yi Shen  <yi.4.shen@nokia.com>
 

trunk/Source/WebCore/dom/Attr.cpp

@@ -27 +27 @@
 #include "ExceptionCode.h"
 #include "HTMLNames.h"
+#include "ScopedEventQueue.h"
 #include "Text.h"
 #include "XMLNSNames.h"
@@ -120 +121 @@
 void Attr::setValue(const AtomicString& value)
 {
+    EventQueueScope scope;
     m_ignoreChildrenChanged++;
     removeChildren();