Changeset 79816 in webkit

Timestamp:

Feb 26, 2011 10:53:21 PM (13 years ago)

Author:

abarth@webkit.org

Message:

2011-02-26 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

<input value="type=submit"> throws a warning (“HTML parse error”)
​https://bugs.webkit.org/show_bug.cgi?id=55120

This patch removes parse error messages from the HTML parser. These
messages are displayed at the wrong times, aren't tested, and aren't
helpful. We'll try again with some more informative messages and
better testing.

• html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLTreeBuilder.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-26  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        <input value="type=submit"> throws a warning (“HTML parse error”)
+        https://bugs.webkit.org/show_bug.cgi?id=55120
+
+        This patch removes parse error messages from the HTML parser.  These
+        messages are displayed at the wrong times, aren't tested, and aren't
+        helpful.  We'll try again with some more informative messages and
+        better testing.
+
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::parseError):
+
 2011-02-26  Patrick Gansterer  <paroga@webkit.org>
 

trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp

@@ -2807 +2807 @@
 void HTMLTreeBuilder::parseError(AtomicHTMLToken&)
 {
-    DEFINE_STATIC_LOCAL(String, parseErrorMessage, ("HTML parse error (recovered gracefully)"));
-
-    if (!m_reportErrors)
-        return;
-
-    DOMWindow* domWindow = m_document->domWindow();
-    if (!domWindow)
-        return;
-
-    domWindow->console()->addMessage(HTMLMessageSource, LogMessageType, WarningMessageLevel, parseErrorMessage, m_parser->lineNumber(), m_document->url().string());
 }