Changeset 79844 in webkit

Timestamp:

Feb 27, 2011 11:30:10 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

2011-02-27 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
​https://bugs.webkit.org/show_bug.cgi?id=53917

The bug got fixed by other changes. Adding test case to avoid
regressions in the future.

• fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
• fast/overflow/horizontal-scroll-after-back.html: Added.

2011-02-27 Aparna Nandyal <​aparna.nand@wipro.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
​https://bugs.webkit.org/show_bug.cgi?id=53917

Adding test case to check the scenario to avoid regressions in the
future.

• tests/qwebframe/tst_qwebframe.cpp:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/overflow/horizontal-scroll-after-back-expected.txt (added)
• LayoutTests/fast/overflow/horizontal-scroll-after-back.html (added)
• Source/WebKit/qt/ChangeLog (modified) (1 diff)
• Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
+        https://bugs.webkit.org/show_bug.cgi?id=53917
+
+        The bug got fixed by other changes. Adding test case to avoid
+        regressions in the future.
+
+        * fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
+        * fast/overflow/horizontal-scroll-after-back.html: Added.
+
 2011-02-27  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebKit/qt/ChangeLog

@@ +1 @@
+2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>
+
+        Reviewed by Antonio Gomes.
+
+        [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
+        https://bugs.webkit.org/show_bug.cgi?id=53917
+
+        Adding test case to check the scenario to avoid regressions in the
+        future. 
+
+        * tests/qwebframe/tst_qwebframe.cpp:
+
 2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
 

trunk/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp

@@ -591 +591 @@
 
 private slots:
+    void horizontalScrollAfterBack();
     void getSetStaticProperty();
     void getSetDynamicProperty();
@@ -3103 +3104 @@
 }
 
+void tst_QWebFrame::horizontalScrollAfterBack()
+{
+    QWebView view;
+    QWebFrame* frame = view.page()->mainFrame();
+    QSignalSpy loadSpy(view.page(), SIGNAL(loadFinished(bool))); 
+
+    view.page()->settings()->setMaximumPagesInCache(2);
+    frame->setScrollBarPolicy(Qt::Vertical, Qt::ScrollBarAsNeeded);
+    frame->setScrollBarPolicy(Qt::Horizontal, Qt::ScrollBarAsNeeded);
+
+    view.load(QUrl("qrc:/testiframe2.html"));
+    view.resize(200, 200);
+    QTRY_COMPARE(loadSpy.count(), 1);
+    QTRY_VERIFY((frame->scrollBarGeometry(Qt::Horizontal)).height());
+
+    view.load(QUrl("qrc:/testiframe.html"));
+    QTRY_COMPARE(loadSpy.count(), 2);
+
+    view.page()->triggerAction(QWebPage::Back);
+    QTRY_COMPARE(loadSpy.count(), 3);
+    QTRY_VERIFY((frame->scrollBarGeometry(Qt::Horizontal)).height());
+}
+
 void tst_QWebFrame::evaluateWillCauseRepaint()
 {