Changeset 79866 in webkit
- Timestamp:
- Feb 28, 2011 8:16:39 AM (13 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r79864 r79866 1 2011-02-28 Renata Hodovan <reni@webkit.org> 2 3 Reviewed by Andreas Kling. 4 5 Optimize parameter transmissions in FEConvolveMatrix. 6 https://bugs.webkit.org/show_bug.cgi?id=55381 7 8 Parameter transmission via reference is more efficient than with copy. So they are substituted. 9 10 No new tests are needed since this is a refactoring. 11 12 * platform/graphics/filters/FEConvolveMatrix.cpp: 13 (WebCore::FEConvolveMatrix::setKernelSize): 14 (WebCore::FEConvolveMatrix::setTargetOffset): 15 (WebCore::FEConvolveMatrix::setKernelUnitLength): 16 * platform/graphics/filters/FEConvolveMatrix.h: 17 1 18 2011-02-28 Yury Semikhatsky <yurys@chromium.org> 2 19 -
trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
r79530 r79866 64 64 } 65 65 66 void FEConvolveMatrix::setKernelSize( IntSizekernelSize)66 void FEConvolveMatrix::setKernelSize(const IntSize& kernelSize) 67 67 { 68 68 m_kernelSize = kernelSize; … … 110 110 } 111 111 112 bool FEConvolveMatrix::setTargetOffset( IntPointtargetOffset)112 bool FEConvolveMatrix::setTargetOffset(const IntPoint& targetOffset) 113 113 { 114 114 if (m_targetOffset == targetOffset) … … 136 136 } 137 137 138 bool FEConvolveMatrix::setKernelUnitLength( FloatPointkernelUnitLength)138 bool FEConvolveMatrix::setKernelUnitLength(const FloatPoint& kernelUnitLength) 139 139 { 140 140 if (m_kernelUnitLength == kernelUnitLength) -
trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h
r79530 r79866 50 50 51 51 IntSize kernelSize() const; 52 void setKernelSize( IntSize);52 void setKernelSize(const IntSize&); 53 53 54 54 const Vector<float>& kernel() const; … … 62 62 63 63 IntPoint targetOffset() const; 64 bool setTargetOffset( IntPoint);64 bool setTargetOffset(const IntPoint&); 65 65 66 66 EdgeModeType edgeMode() const; … … 68 68 69 69 FloatPoint kernelUnitLength() const; 70 bool setKernelUnitLength( FloatPoint);70 bool setKernelUnitLength(const FloatPoint&); 71 71 72 72 bool preserveAlpha() const;
Note: See TracChangeset
for help on using the changeset viewer.