Changeset 79866 in webkit


Ignore:
Timestamp:
Feb 28, 2011 8:16:39 AM (13 years ago)
Author:
reni@webkit.org
Message:

2011-02-28 Renata Hodovan <reni@webkit.org>

Reviewed by Andreas Kling.

Optimize parameter transmissions in FEConvolveMatrix.
https://bugs.webkit.org/show_bug.cgi?id=55381

Parameter transmission via reference is more efficient than with copy. So they are substituted.

No new tests are needed since this is a refactoring.

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::setKernelSize): (WebCore::FEConvolveMatrix::setTargetOffset): (WebCore::FEConvolveMatrix::setKernelUnitLength):
  • platform/graphics/filters/FEConvolveMatrix.h:
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r79864 r79866  
     12011-02-28  Renata Hodovan  <reni@webkit.org>
     2
     3        Reviewed by Andreas Kling.
     4
     5        Optimize parameter transmissions in FEConvolveMatrix.
     6        https://bugs.webkit.org/show_bug.cgi?id=55381
     7
     8        Parameter transmission via reference is more efficient than with copy. So they are substituted.
     9
     10        No new tests are needed since this is a refactoring.
     11
     12        * platform/graphics/filters/FEConvolveMatrix.cpp:
     13        (WebCore::FEConvolveMatrix::setKernelSize):
     14        (WebCore::FEConvolveMatrix::setTargetOffset):
     15        (WebCore::FEConvolveMatrix::setKernelUnitLength):
     16        * platform/graphics/filters/FEConvolveMatrix.h:
     17
    1182011-02-28  Yury Semikhatsky  <yurys@chromium.org>
    219
  • trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp

    r79530 r79866  
    6464}
    6565
    66 void FEConvolveMatrix::setKernelSize(IntSize kernelSize)
     66void FEConvolveMatrix::setKernelSize(const IntSize& kernelSize)
    6767{
    6868    m_kernelSize = kernelSize;
     
    110110}
    111111
    112 bool FEConvolveMatrix::setTargetOffset(IntPoint targetOffset)
     112bool FEConvolveMatrix::setTargetOffset(const IntPoint& targetOffset)
    113113{
    114114    if (m_targetOffset == targetOffset)
     
    136136}
    137137
    138 bool FEConvolveMatrix::setKernelUnitLength(FloatPoint kernelUnitLength)
     138bool FEConvolveMatrix::setKernelUnitLength(const FloatPoint& kernelUnitLength)
    139139{
    140140    if (m_kernelUnitLength == kernelUnitLength)
  • trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h

    r79530 r79866  
    5050
    5151    IntSize kernelSize() const;
    52     void setKernelSize(IntSize);
     52    void setKernelSize(const IntSize&);
    5353
    5454    const Vector<float>& kernel() const;
     
    6262
    6363    IntPoint targetOffset() const;
    64     bool setTargetOffset(IntPoint);
     64    bool setTargetOffset(const IntPoint&);
    6565
    6666    EdgeModeType edgeMode() const;
     
    6868
    6969    FloatPoint kernelUnitLength() const;
    70     bool setKernelUnitLength(FloatPoint);
     70    bool setKernelUnitLength(const FloatPoint&);
    7171
    7272    bool preserveAlpha() const;
Note: See TracChangeset for help on using the changeset viewer.